Fix window--display-buffer advice #1173

Forgot to have the :filter-return advice return the window (whoops!)
This commit is contained in:
Henrik Lissner 2019-02-16 01:16:09 -05:00
parent 81e30dc13c
commit 93132e43c1
No known key found for this signature in database
GPG key ID: 5F6C0EA160557395

View file

@ -586,7 +586,8 @@ Accepts the same arguments as `display-buffer-in-side-window'. You must set
This was not so until recent Emacs 27 builds, where it causes breaking errors. This was not so until recent Emacs 27 builds, where it causes breaking errors.
This advice ensures backwards compatibility for Emacs <= 26 users." This advice ensures backwards compatibility for Emacs <= 26 users."
(when (and (windowp window) display-buffer-mark-dedicated) (when (and (windowp window) display-buffer-mark-dedicated)
(set-window-dedicated-p window display-buffer-mark-dedicated))) (set-window-dedicated-p window display-buffer-mark-dedicated))
window)
(advice-add #'window--display-buffer :filter-return #'+popup*set-window-dedicated)) (advice-add #'window--display-buffer :filter-return #'+popup*set-window-dedicated))
(unless EMACS26+ (unless EMACS26+