From 93132e43c19bdbe671a6e8cc9eef663b5fb70da8 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Sat, 16 Feb 2019 01:16:09 -0500 Subject: [PATCH] Fix window--display-buffer advice #1173 Forgot to have the :filter-return advice return the window (whoops!) --- modules/ui/popup/autoload/popup.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/ui/popup/autoload/popup.el b/modules/ui/popup/autoload/popup.el index 44b9e2185..4c7002225 100644 --- a/modules/ui/popup/autoload/popup.el +++ b/modules/ui/popup/autoload/popup.el @@ -586,7 +586,8 @@ Accepts the same arguments as `display-buffer-in-side-window'. You must set This was not so until recent Emacs 27 builds, where it causes breaking errors. This advice ensures backwards compatibility for Emacs <= 26 users." (when (and (windowp window) display-buffer-mark-dedicated) - (set-window-dedicated-p window display-buffer-mark-dedicated))) + (set-window-dedicated-p window display-buffer-mark-dedicated)) + window) (advice-add #'window--display-buffer :filter-return #'+popup*set-window-dedicated)) (unless EMACS26+