emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

nit: revise site-lisp comments

Browse source 
The motivations for delaying the site-lisp files are different between
interactive and non-interactive sessions. I've revised these comments to
reflect that.
This commit is contained in:
Henrik Lissner 2024-07-12 18:15:26 -04:00
parent b9f1d5d261
commit 8ab42fa774
No known key found for this signature in database
GPG key ID: B60957CA074D39A3
2 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lisp/doom-cli.el
View file

@ -23,11 +23,12 @@
doom-cache-dir
doom-state-dir))
;; HACK: bin/doom invokes Emacs with --no-site-lisp solely to allow us to load
;; site-start manually, here, to suppress any output it produces, and they
;; almost always produce some. This causes premature redraws of the Emacs
;; frame during startup (to display those messages in the minibuffer), which
;; -- as I mention in the comments of doom.el -- really hurts startup time.
;; HACK: bin/doom invokes Emacs with --no-site-lisp so that site files can be
;; loaded manually, here, where I can suppress any output it produces, and
;; they almost always produce some. This output pollutes the output of doom
;; scripts with potentially confusing -- but always unimportant --
;; information to the user, like deprecation notices, file-loaded messages,
;; and linter warnings. With this, that output is suppressed.
(quiet!
(require 'cl nil t)
(unless site-run-file

13
lisp/doom.el
View file

@ -487,12 +487,13 @@ users).")
;; later (see `startup--load-user-init-file@undo-hacks').
(advice-add #'tool-bar-setup :override #'ignore)
;; PERF,UX: site-lisp files are often obnoxiously noisy (emitting load
;; messages or other output to *Messages* or stdout). These queue
;; unnecessary redraws at startup which impact startup time depending on
;; window system. It also pollutes the logs. By suppressing it now, I can
;; load it myself, later, in a more controlled way (see
;; `startup--load-user-init-file@undo-hacks').
;; PERF,UX: site-lisp files are often obnoxiously noisy (emitting output
;; that isn't useful to end-users, like load messages, deprecation
;; notices, and linter warnings. Displaying these in the minibuffer causes
;; unnecessary redraws at startup which can impact startup time
;; drastically and cause flashes of white. It also pollutes the logs. By
;; suppressing it here, I load it myself, later, in a more controlled way
;; (see `startup--load-user-init-file@undo-hacks').
(put 'site-run-file 'initial-value site-run-file)
(setq site-run-file nil)