From 8ab42fa774bac1130bc159c89d714e04a4fa8ac6 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Fri, 12 Jul 2024 18:15:26 -0400 Subject: [PATCH] nit: revise site-lisp comments The motivations for delaying the site-lisp files are different between interactive and non-interactive sessions. I've revised these comments to reflect that. --- lisp/doom-cli.el | 11 ++++++----- lisp/doom.el | 13 +++++++------ 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/lisp/doom-cli.el b/lisp/doom-cli.el index cf32f6505..666551311 100644 --- a/lisp/doom-cli.el +++ b/lisp/doom-cli.el @@ -23,11 +23,12 @@ doom-cache-dir doom-state-dir)) - ;; HACK: bin/doom invokes Emacs with --no-site-lisp solely to allow us to load - ;; site-start manually, here, to suppress any output it produces, and they - ;; almost always produce some. This causes premature redraws of the Emacs - ;; frame during startup (to display those messages in the minibuffer), which - ;; -- as I mention in the comments of doom.el -- really hurts startup time. + ;; HACK: bin/doom invokes Emacs with --no-site-lisp so that site files can be + ;; loaded manually, here, where I can suppress any output it produces, and + ;; they almost always produce some. This output pollutes the output of doom + ;; scripts with potentially confusing -- but always unimportant -- + ;; information to the user, like deprecation notices, file-loaded messages, + ;; and linter warnings. With this, that output is suppressed. (quiet! (require 'cl nil t) (unless site-run-file diff --git a/lisp/doom.el b/lisp/doom.el index 9e8626122..24302d193 100644 --- a/lisp/doom.el +++ b/lisp/doom.el @@ -487,12 +487,13 @@ users).") ;; later (see `startup--load-user-init-file@undo-hacks'). (advice-add #'tool-bar-setup :override #'ignore) - ;; PERF,UX: site-lisp files are often obnoxiously noisy (emitting load - ;; messages or other output to *Messages* or stdout). These queue - ;; unnecessary redraws at startup which impact startup time depending on - ;; window system. It also pollutes the logs. By suppressing it now, I can - ;; load it myself, later, in a more controlled way (see - ;; `startup--load-user-init-file@undo-hacks'). + ;; PERF,UX: site-lisp files are often obnoxiously noisy (emitting output + ;; that isn't useful to end-users, like load messages, deprecation + ;; notices, and linter warnings. Displaying these in the minibuffer causes + ;; unnecessary redraws at startup which can impact startup time + ;; drastically and cause flashes of white. It also pollutes the logs. By + ;; suppressing it here, I load it myself, later, in a more controlled way + ;; (see `startup--load-user-init-file@undo-hacks'). (put 'site-run-file 'initial-value site-run-file) (setq site-run-file nil)