nit(mu4e): neutralize comments

Some of our comments/docs can come off as disparaging or snide. They're
glimpses of unfiltered frustration or snarky rubber ducking gone too
far, something I can totally sympathize with, as a scatterbrained
tinkerer, unwittingly made responsible for a lot of work that isn't mine
because of Doom's position as a middleman. But now that Doom has a
veritable userbase, I'd like to hold it to a higher standard.

Light-hearted banter and aired grievances in our source code,
documentation, or community are fine if focused on the problem or the
personal/shared experiences of the community (things that offer value or
amusement to others), but it is never acceptable to attack people or
their efforts. Especially not the very people on whose shoulders Doom
stands.

I sincerely apologize if these have offended you.

Amend: b07614037f
This commit is contained in:
Henrik Lissner 2022-08-10 23:06:45 +02:00
parent 02bb28dc82
commit 3239ab8b2e
No known key found for this signature in database
GPG key ID: B60957CA074D39A3
6 changed files with 16 additions and 22 deletions

View file

@ -1,11 +1,10 @@
;;; lisp/cli/autoloads.el -*- lexical-binding: t; -*- ;;; lisp/cli/autoloads.el -*- lexical-binding: t; -*-
(defvar doom-autoloads-excluded-packages () (defvar doom-autoloads-excluded-packages ()
"What packages whose autoloads files we won't index. "Which packages to exclude from Doom's autoloads files.
These packages have silly or destructive autoload files that try to load Use this for packages with problematic autoloads; e.g. they autoload too much or
everyone in the universe and their dog, causing errors that make babies cry. No hoist buggy forms into autoloads.")
one wants that.")
(defvar doom-autoloads-excluded-files () (defvar doom-autoloads-excluded-files ()
"List of regexps whose matching files won't be indexed for autoloads.") "List of regexps whose matching files won't be indexed for autoloads.")

View file

@ -24,8 +24,8 @@
(expand-file-name ".attachments" (mu4e-root-maildir)))) (expand-file-name ".attachments" (mu4e-root-maildir))))
:config :config
(when (version< mu4e-mu-version "1.8") (when (version< mu4e-mu-version "1.8")
;; Evidently the mu4e author has never heard of `define-obsolete-function-alias'. ;; Define aliases to maintain backwards compatibility. The list of suffixes
;; List of suffixes obtained by comparing mu4e~ and mu4e-- functions in `obarray'. ;; were obtained by comparing mu4e~ and mu4e-- functions in `obarray'.
(dolist (transferable-suffix (dolist (transferable-suffix
'("check-requirements" "contains-line-matching" "context-ask-user" '("check-requirements" "contains-line-matching" "context-ask-user"
"context-autoswitch" "default-handler" "get-folder" "get-log-buffer" "context-autoswitch" "default-handler" "get-folder" "get-log-buffer"

View file

@ -90,10 +90,9 @@
"Use lsp completion instead of cider." "Use lsp completion instead of cider."
(remove-hook 'completion-at-point-functions #'cider-complete-at-point t)))) (remove-hook 'completion-at-point-functions #'cider-complete-at-point t))))
;; Error messages emitted from CIDER is silently funneled into *nrepl-server* ;; UX: CIDER's error messages get quietly funneled into *nrepl-server*. That
;; rather than the *cider-repl* buffer. How silly. We might want to see that ;; sort of information would be more helpful displayed front and center when
;; stuff and who's going to check *nrepl-server* on every startup? I've got a ;; opening a *cider-repl*.
;; better idea: we copy these errors into the *cider-repl* buffer.
(add-hook! 'cider-connected-hook (add-hook! 'cider-connected-hook
(defun +clojure--cider-dump-nrepl-server-log-h () (defun +clojure--cider-dump-nrepl-server-log-h ()
"Copy contents of *nrepl-server* to beginning of *cider-repl*." "Copy contents of *nrepl-server* to beginning of *cider-repl*."

View file

@ -16,13 +16,10 @@ This module adds support for PHP 5.3+ (including PHP7) to Doom Emacs.
- [[https://github.com/hlissner/doom-snippets/tree/master/php-mode][Snippets]] - [[https://github.com/hlissner/doom-snippets/tree/master/php-mode][Snippets]]
#+begin_quote #+begin_quote
💡 PHP was the first programming language I got paid to code in, back in the 💬 PHP was the first programming language I got paid to code in, back in the
Cretaceous period (2003). My sincerest apologies go out to all the Cretaceous period (2003). My sincerest apologies go out to all the
programmers who inherited my earliest PHP work. I know you're out there, programmers who inherited my earliest PHP work. I know you're out there,
writhing in your straitjackets. writhing in your straitjackets.
Save a programmer today. Stop a friend from choosing PHP as their first
language.
#+end_quote #+end_quote
** Maintainers ** Maintainers

View file

@ -57,7 +57,7 @@
(setq python-indent-guess-indent-offset-verbose nil) (setq python-indent-guess-indent-offset-verbose nil)
;; Default to Python 3. Prefer the versioned Python binaries since some ;; Default to Python 3. Prefer the versioned Python binaries since some
;; systems stupidly make the unversioned one point at Python 2. ;; systems link the unversioned one to Python 2.
(when (and (executable-find "python3") (when (and (executable-find "python3")
(string= python-shell-interpreter "python")) (string= python-shell-interpreter "python"))
(setq python-shell-interpreter "python3")) (setq python-shell-interpreter "python3"))

View file

@ -3,14 +3,13 @@
;; DEPRECATED Remove this when we drop Emacs 27 support. ;; DEPRECATED Remove this when we drop Emacs 27 support.
;; HACK Eshell resets its keymap every time `eshell-mode' is enabled. Why? It ;; HACK Eshell resets its keymap every time `eshell-mode' is enabled. This is
;; is not for us mere mortals to question! Anyhow, we undo this brilliant ;; fixed in Emacs 28+, but this file backports that fix for 27 users. This
;; design by backporting the fix from Emacs 28, so keys can be bound to ;; way, keys can be safely bound to `eshell-mode-map' and `eshell-command-map'
;; `eshell-mode-map' & `eshell-command-map' like any normal keymap, ;; like any normal keymap, rather than a hook.
;; rather than in a hook.
;; ;;
;; Fun fact: there's a "FIXME What the hell?!" above the offending line ;; Fun fact: there's a "FIXME What the hell?!" above the offending line in
;; in esh-mode.el. ;; esh-mode.el.
;;;###autoload ;;;###autoload
(defvar eshell-mode-map (defvar eshell-mode-map