;;; core-popup.el --- taming stray windows ;; I use a slew of hackery to get Emacs to treat 'pop-ups' consistently. It goes ;; through great lengths to tame helm, flycheck, help buffers--*even* the beast ;; that is org-mode, with the help of `display-buffer-alist' and shackle. ;; ;; Be warned, an update could break this. (use-package shackle :config (shackle-mode 1) (setq shackle-rules `(;; Util ("^\\*.+-Profiler-Report .+\\*$" :align below :size 0.3 :regexp t) ("*esup*" :align below :size 0.4 :noselect t) ("*minor-modes*" :align below :size 0.5 :noselect t) ("*eval*" :align below :size 16 :noselect t) ;; Doom (" *doom*" :align below :size 35 :select t) ("^\\*doom:.+\\*$" :align below :size 35 :select t :regexp t) ("^\\*doom.+\\*$" :align below :size 12 :noselect t :regexp t) ;; Emacs ("*Pp Eval Output*" :align below :size 0.3) ("*Apropos*" :align below :size 0.3) ("*Backtrace*" :align below :size 25 :noselect t) ("*Help*" :align below :size 16 :select t) ("*Messages*" :align below :size 15 :select t) ("*Warnings*" :align below :size 10 :noselect t) (compilation-mode :align below :size 15 :noselect t) (eww-mode :align below :size 30 :select t) ("*command-log*" :align right :size 28 :noselect t) ;; vcs ("*vc-diff*" :align below :size 15 :noselect t) ("*vc-change-log*" :align below :size 15 :select t) (vc-annotate-mode :same t))) ;; Emacs 25.1+ properly shows the completion window at the bottom of the ;; current frame. (unless (version< emacs-version "25.1") (push '("*Completions*" :align below :size 30 :noselect t) shackle-rules)) ;; :noesc = Can't be closed with a single ESC ;; :nokill = Won't be killed when closed (only buried) (defvar doom-popup-rules '(("^\\*doom\\(:scratch\\)?\\*$" :noesc :nokill) ("^\\*doom.*\\*$" :noesc :nokill) (ivy-occur-grep-mode :noesc) (compilation-mode :noesc) (comint-mode :noesc :nokill) (eshell-mode :noesc :nokill) (messages-buffer-mode :nokill) (esup-mode :noesc) (tabulated-list-mode :noesc))) ;; There is no shackle-popup hook, so I created one: (advice-add 'shackle-display-buffer :around 'doom*popup-init) ;; Tell these functions not to mess with popups: (advice-add 'balance-windows :around 'doom*save-popup) (advice-add 'doom/evil-window-move :around 'doom*save-popup)) ;; ;; Hacks ;; (after! help-mode ;; Help buffers use itself (or `other-window') to decide where to open ;; followed links, which can be unpredictable. It should *only* replace the ;; original buffer we opened the popup from. To fix this these three button ;; types need to be redefined to set aside the popup before following a link. (define-button-type 'help-function-def :supertype 'help-xref 'help-function (lambda (fun file) (require 'find-func) (when (eq file 'C-source) (setq file (help-C-file-name (indirect-function fun) 'fun))) (let ((location (find-function-search-for-symbol fun nil file))) (doom/popup-close) (switch-to-buffer (car location) nil t) (if (cdr location) (goto-char (cdr location)) (message "Unable to find location in file"))))) (define-button-type 'help-variable-def :supertype 'help-xref 'help-function (lambda (var &optional file) (when (eq file 'C-source) (setq file (help-C-file-name var 'var))) (let ((location (find-variable-noselect var file))) (doom/popup-close) (switch-to-buffer (car location) nil t) (if (cdr location) (goto-char (cdr location)) (message "Unable to find location in file"))))) (define-button-type 'help-face-def :supertype 'help-xref 'help-function (lambda (fun file) (require 'find-func) (let ((location (find-function-search-for-symbol fun 'defface file))) (doom/popup-close) (switch-to-buffer (car location) nil t) (if (cdr location) (goto-char (cdr location)) (message "Unable to find location in file")))))) (add-hook! org-load ;; Ensures org-src-edit yields control of its buffer to shackle. (defun org-src-switch-to-buffer (buffer context) (pop-to-buffer buffer)) ;; And these for org-todo, org-link and org-agenda (defun org-pop-to-buffer-same-window (&optional buffer-or-name norecord label) "Pop to buffer specified by BUFFER-OR-NAME in the selected window." (display-buffer buffer-or-name)) (defun org-switch-to-buffer-other-window (&rest args) (car-safe (mapc (lambda (b) (let ((buf (if (stringp b) (get-buffer-create b) b))) (pop-to-buffer buf t t))) args))) (defun doom/org-agenda-quit () "Necessary to finagle org-agenda into shackle popups and behave properly on quit." (interactive) (if org-agenda-columns-active (org-columns-quit) (let ((buf (current-buffer))) (and (not (eq org-agenda-window-setup 'current-window)) (not (one-window-p)) (delete-window)) (kill-buffer buf) (setq org-agenda-archives-mode nil org-agenda-buffer nil)))) (after! org-agenda (map! :map org-agenda-mode-map :e "" 'doom/org-agenda-quit :e "ESC" 'doom/org-agenda-quit :e [escape] 'doom/org-agenda-quit "q" 'doom/org-agenda-quit "Q" 'doom/org-agenda-quit))) (provide 'core-popup) ;;; core-popup.el ends here