Commit graph

22 commits

Author SHA1 Message Date
Zdeněk 'Vlk' Mžourek
6bea1f6a35 perf(lsp): turn off eglot events buffer
The `eglot-events-buffer-size` setting disables the `eglot-events-buffer`
when 0, enabling more consistent performance on long running emacs
instance.
Default is 2000000 lines. After each new event the events buffer
is pretty printed as a whole, which causes steady performance decrease
over time.
Quite a bit of CPU is spent on pretty priting and Emacs GC is put under
high pressure.
2023-11-24 10:42:42 -05:00
Jeetaditya Chatterjee
37bfe0824b
tweak(lsp): feature gate flycheck eglot
When flymake is enabled.
2023-07-25 00:19:12 +01:00
Jeetaditya Chatterjee
b957142e3e
feat(lsp): use flymake when enabled 2023-07-24 23:51:40 +01:00
Ellis Kenyo
81ec1a70d0 fix(lsp): advise eglot-ensure to always load
Advise eglot-ensure to only attempt to run when the mode in question has
a server configured
2023-07-22 16:41:13 +02:00
Henrik Lissner
25611707ed
refactor(lsp): switch to flycheck-eglot package
We no longer need to maintain our own juryrigged version of this
functionality.
2023-02-21 03:30:51 -05:00
Henrik Lissner
ad6a3d0f33
refactor: deprecate featurep! for modulep!
featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.

featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.
2022-08-14 20:43:35 +02:00
Itai Y. Efrat
d2d940fdf1 feat(lsp,vertico): add consult-eglot
- Load when :tools lsp +eglot and :completion vertico are on
- Bind consult-eglot-symbols to <leader> c j
2021-09-15 01:03:11 +03:00
Nham Le
6678f3833b
fix(lsp): explicitly set xref handlers for eglot
Otherwise a major mode's lookup handlers may take precedence (e.g. in
go-mode).

Close #5329
2021-08-06 03:50:33 -04:00
Henrik Lissner
06392a723f refactor: rename orig-fn arg in advice to fn
A minor tweak to our naming conventions for the first argument of an
:around advice.
2021-08-04 01:53:12 -04:00
Gerry Agbobada
813dc6e664
fix(:tools lsp): make eglot diags use flycheck with :checkers syntax
Research on how Flycheck work, and a pending fix from Eglot, allowed to
get a cleaner representation of how this "hack" works and make it more
resilient

Co-Authored-By: Steve Purcell <steve@sanityinc.com>
2021-04-14 09:09:37 +02:00
Henrik Lissner
22b6eaed03
Rethink lsp defaults
+ Allow LSP to prompt to install servers. All this machinary just adds
more confusion for beginners, and at least LSP asks for your permission
before it does it.
+ Reverts lsp-enable-file-watchers and lsp-enable-indentation to their
default (enabled), hopefully to help lsp-java, lsp-dart, and lsp-clojure
users, for whom file-watchers seems to be necessary.
+ Apply GC/IPC optimizations globally, to ensure their reach. By only
setting them buffer-locally we don't have a guarantee that subprocesses
will be affected when the lsp buffer isn't focused.

Closes #3989

Co-authored-by: Eric Dallo <ercdll1337@gmail.com>
2020-10-11 18:32:42 -04:00
Henrik Lissner
4e82ee4397
Refactor doom-debug-mode
+ Add explain-pause-mode
+ Now reloads itself if doom-debug-variables is changed or when one of
  its variables becomes available.
+ doom-debug-variables now supports a cons cell entry where its CAR is
  the name of the variable and CDR is the value it should be set to when
  doom-debug-mode is active.
2020-08-21 01:26:24 -04:00
Henrik Lissner
06c6946742
tools/lsp: defer auto-shutdown of eglot server 2020-08-21 00:03:01 -04:00
Henrik Lissner
9e9b95f49c
Fix #3789: fix eglot lookup-documentation handler
Eglot replaced `eglot-help-at-point' in joaotavora/eglot@a044dec,
breaking our documentation lookup handler.
2020-08-20 14:07:47 -04:00
Henrik Lissner
6cf5d72ff6
Generalize LSP optimizations to include eglot 2020-08-12 00:34:09 -04:00
Seong Yong-ju
d8c6030a14 tools/lsp: Use general implementation lookup handler 2020-06-24 01:56:26 +09:00
Henrik Lissner
d502c7c06a
tools/lsp: minor refactors 2020-05-28 22:01:23 -04:00
Gerry Agbobada
dc3c2f9e78
[review] no extension in load! / rename interactive function 2020-05-28 13:13:00 +02:00
Gerry Agbobada
c41ae8995b
Remove redundant featurep! check 2020-05-28 11:50:24 +02:00
Gerry Agbobada
f35768af86
Fix loading of flycheck-eglot 2020-05-28 11:19:33 +02:00
Gerry Agbobada
718d9a2690
[review] Changes 2020-05-28 11:17:55 +02:00
Gerry Agbobada
6a163fd5c1
[review] create +lsp.el and +eglot.el files
This means we can remove a lot of `:unless (featurep! +eglot)`
2020-05-28 11:17:55 +02:00