Commit graph

16208 commits

Author SHA1 Message Date
Itai Y. Efrat
34f8e1fdec vertico: Improve README and update TODO...
- Add basic configuration instructions
- Add Vertico keybindings
- Improve =C-c C-e= documentation
- Prepare TODO for PR review
2021-07-25 02:52:04 +03:00
Itai Y. Efrat
a0eb4e9b65 completion/selectrum -> completion/vertico, part 3
- Rename all functions and variables in the module to reflect the
  namechange (and the irc jump function)
2021-07-25 02:52:04 +03:00
Itai Y. Efrat
24eaa1317c completion/selectrum -> completion/vertico, part 2
- Rename module from `:completion selectrum` to `:completion vertico`
- Rename all files involved
- Do *not* yet rename all the functions, as that messes up git's rename
  detection.
2021-07-25 02:51:15 +03:00
Itai Y. Efrat
f9e1c99b2b completion/selectrum -> completion/vertico, part 1
- Use `vertico` as default completion engine
- Drop `selectrum` and `selectrum-prescient` support
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
dc6da589be selectrum: fix false positive marginalia annotation...
for `flycheck-error-list-set-filter`.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
794b8c2383 selectrum: add vertico-repeat support
Also change the `vertico` recipe to be able to use extensions.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
29c49f727e selectrum: use consult-completing-read-multiple 2021-07-25 02:50:42 +03:00
Itai Y. Efrat
debba41403 Bump :completion selectrum
minad/vertico@c915775 -> minad/vertico@9f6cd5d
raxod502/selectrum@a19bbe9 -> raxod502/selectrum@48ea51a
minad/consult@f1ae224 -> minad/consult@f17db95
minad/marginalia@e31e03c -> minad/marginalia@3bf0a4d
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
bc9d2bf3a4 selectrum: better completion-in-region-function
`consult-completion-in-region` isn't meant to be used without a vertical
completion framework
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
814c5b5c0c selectrum: improve company advice
- try `basic` and `partial-completion` completion styles before
  `orderless`, since `company-mode` is usually used in in-buffer
  completions where these often give much more relevant results than
  orderless, which can still be accessed by `&`.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
d86375a468 selectrum: add icon support
Use the package `all-the-icons-completion` to add icons to vertical
completion buffers.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
92586cacd4 selectrum: remove doom-project-find-file hack
This solution doesn't rely on condition evaluation order, and doesn't
contain `featurep!`'s unnecessarily.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
e65dffd790 selectrum: remove selectrum-minibuffer-map from...
`+default-minibuffer-maps`.

It's derived from `minibuffer-local-map` so this is unnecessary.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
d3eff82b9d selectrum: add experimental vertico flag 2021-07-25 02:50:42 +03:00
Itai Y. Efrat
78955d8a64 selectrum: add preview debounce for consult-theme 2021-07-25 02:50:42 +03:00
Itai Y. Efrat
2e6a04e536 selectrum: remove embark export/collect popup rules
They don't seem to be necessary anymore, and cause issues with window
opening logic when clicking on links in exported grep buffers.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
7c313fbac2 selectrum: autoload +selectrum/backward-updir...
and make it independent of selectrum
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
336ad46c47 selectrum: clean up selectrum config
- remove unnecessary configuration of `selectrum` and
  `selectrum-prescient`
- fix type of `selectrum-fix-vertical-window-height`
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
83abd71db7 selectrum: update TODO, add docs/modules.org entry 2021-07-25 02:50:42 +03:00
Itai Y. Efrat
3283acbde9 selectrum: use default values for consult async timers
unclear why `consult-async-input-(debounce|throttle)` were set to custom
higher values in the first place.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
53e2c32a69 Bump consult-lsp
gagbo/consult-lsp@ed3cfd2 ->  gagbo/consult-lsp@c882749
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
5a44c1f880 selectrum: remove side effect in irc jump function
`+irc/selectrum-jump-to-channel` previously modified
`+irc--consult-circe-source` in the definition, since `plist-put`, and I
quote from the manual:
"[] may modify plist destructively, or [] may construct a new list
structure without altering the old."
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
f315a60ccc Bump :completion selectrum
raxod502/selectrum@a922b19 -> raxod502/selectrum@a19bbe9
oantolin/orderless@9637d7f -> oantolin/orderless@2646dad
minad/consult@a4b4ced -> minad/consult@f1ae224
minad/consult-flycheck@44e7528 -> minad/consult-flycheck@92b259e
oantolin/embark@0da967a -> oantolin/embark@acbe1cb
minad/marginalia@3f33b38 -> minad/marginalia@e31e03c
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
fad34eb718 selectrum: README changes, TODO overhaul...
- Add explanation for orderless usage
- Minor wording improvements
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
573bd73411 selectrum: annotate more functions 2021-07-25 02:50:42 +03:00
Yoav Marco
540c523023 Selectrum: add embark action to open file in new workspace 2021-07-25 02:50:42 +03:00
Itai Y. Efrat
ebd72b715e selectrum: remove some bindings
- the embark actions use packages that aren't installed or don't work
- the selectrum minibuffer bindings use the super key, which will
  probably conflict with tiling window managers
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
c056e718a8 selectrum: don't override embark-target-finders...
rather, modify it by inserting `+selectrum-embark-target-package!` in the
correct position. overriding it with `setq` is a bad idea since it might
be modified by other packages beforehand, or changed upstream later on.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
e5e75e8dc5 selectrum: override embark-package-map with doom...
related functions
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
e5f3166caf selectrum: add embark target for package! statements 2021-07-25 02:50:42 +03:00
Itai Y. Efrat
8aea99c770 selectrum: rework setq's for selectrum use-package
- display all candidates that fit, displaying only 15 leaves a gap
- move all of them to `:init` since they can be there
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
8c75e07497 selectrum: reorganize keybinding locations
- bind to `minibuffer-local-map` instead of `selectrum-minibuffer-map`
  when possible.
- move bindings and remaps to be under their relevant `use-package!`
  statements.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
4359d96c4c selectrum: use consult-customize for preview keys 2021-07-25 02:50:42 +03:00
Itai Y. Efrat
59ca6186d2 Bump :completion selectrum
minad/consult@4ca7747 -> minad/consult@a4b4ced
minad/consult-flycheck@4ca7747 -> minad/consult-flycheck@44e7528
oantolin/embark@22875aa -> oantolin/embark@0da967a
minad/marginalia@624028c -> minad/marginalia@3f33b38

Note that before this bump consult-flycheck was in the consult repo, but
has since been moved to it's own repo due to consult's pending
submission to ELPA
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
f136521c19 selectrum: sudo-edit -> doom/sudo-find-file...
doom doesn't use `sudo-edit`
also update TODO with subsequent marginalia tasks
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
f29f6beec2 selectrum: embark changes...
- move `marginalia-cycle` binding to `M-A` as it doesn'r work as an
embark action.
- add popup rule to Embark Collect buffers
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
36faa0c258 selectrum: bind embark-act to SPC a and C-;...
not final, might change in the review
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
ed283c6363 selectrum: make workspace source number consistent
The off-by-one of the keybinding and the function input now match
functions like `+workspace/switch-to-$n`
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
14d6613192 selectrum: refactor consult stuff
- use `consult-preview-at-point-mode` instead of `consult-preview-minor-mode`
- better consult preview function detection in `+selectrum/embark-preview`
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
1f3281734a Bump :completion selectrum
minad/consult@556ff4e -> minad/consult@4ca7747
oantolin/embark@a21e510 -> oantolin/embark@22875aa

bumping early to solve `embark-become` bug, see oantolin/embark#230
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
89fd6b66b3 selectrum: add preview to non-consult functions 2021-07-25 02:50:42 +03:00
Itai Y. Efrat
188fc09d72 selectrum: improve SPC b b
- Now uses a consult backend
- has buffer preview, per workspace narrowing with `$n SPC`
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
23a63ba5c4 selectrum: generalize +selectrum/embark-wgrep
now tries to open a writable export of the same vein.
add exports to `wdired` from `find-file` and `occur-edit` from `consult-line`.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
85be33556b selectrum: simplify +selectrum/embark-wgrep
now that oantolin/embark#226 has been resolved.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
436794aa87 Bump :completion selectrum
raxod502/selectrum@909f614 -> raxod502/selectrum@a922b19
minad/consult@a7964f6 -> minad/consult@556ff4e
oantolin/embark@0086413 -> oantolin/embark@a21e510
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
308c6798d3 selectrum: drop foo! orderless style dispatch
conflicts with `!` final macros.
also elaborate why we should drop the prescient flag
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
747f1e38b3 selectrum: update TODO.org 2021-07-25 02:50:42 +03:00
Itai Y. Efrat
24f2efd8ca selectrum: refactor +irc/selectrum-jump-to-channel 2021-07-25 02:50:42 +03:00
Itai Y. Efrat
49a5c51615 selectrum: fix bugs when counsel is loaded (hack)
some doom functions check the completion module with `fboundp`'s instead
of `featurep!`, and counsel can be loaded by using e.g. `lispy`. we add
temporary fixes for this by checking for selectrum stuff first, but this
should be given a more robust fix later on

also we document the selectrum PR's hacks in the TODO.org

see discussion on #5013
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
23a47acc06 selectrum: set manual preview to all grep variants 2021-07-25 02:50:42 +03:00