emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
19166 commits 1 branch 0 tags 33 MiB
Commit graph

73 commits

Author SHA1 Message Date
Tim Ruffing
1c8f1b743a fix(popup): fix finding of major side window 
Fix: #7647
Amend: #7598
 2024-02-11 03:56:20 +01:00
Henrik Lissner
5ef7075f96
nit(popup): mention post-command-select-window for 30.x+ 
Ref: emacs-mirror/emacs@6f75d0f36d
 2024-02-08 00:58:20 -05:00
Tim Ruffing
dca4e4a8ed fix(popup): find internal major side windows 
Fix: #5485
 2024-01-24 12:16:58 -05:00
Henrik Lissner
d8372b6e2d
fix(popup): +popup/raise: recursive popup 
Without this, raising a popup might result in simply opening a popup
with the same rules.
 2023-09-11 23:53:59 +02:00
StrawberryTea
177157b044
fix(popup): cycle windows with no-other-window property 
Previously, +popup/other would do nothing if a window with the
no-other-window property that was not a popup was focused. Now
+popup/other will always select different window if there is another
popup or window with the no-other-window property.

Fix: #7119
 2023-07-24 19:18:53 +02:00
Henrik Lissner
06392a723f refactor: rename orig-fn arg in advice to fn 
A minor tweak to our naming conventions for the first argument of an
:around advice.
 2021-08-04 01:53:12 -04:00
Itai Y. Efrat
34fae1c01c Remove remaining Emacs27+ checks 
- Remove remaining `EMACS27+` checks, since the whole codebase is
  assumed to run at version 27 or above now
- Remove `EMACS27+` definition since it's no longer needed
 2021-07-10 16:03:41 +03:00
Henrik Lissner
11cbd41b1b Fix process X is not a subprocess errors 
When killing repl popups with special processes (e.g. for cider).
 2021-03-13 16:33:18 -05:00
Mikhail Skorzhinskii
9c510159ff popup.el: consider auto-saving indirect buffers too 
Function (buffer-file-name) always returns nil with indirect buffer as
an argument. Extracting base buffer and checking if base buffer visiting
file fixes data loss in indirect buffers showed in popups.

E-mail thread in the org-mode mailing list:

  https://lists.gnu.org/archive/html/emacs-orgmode/2020-12/msg00085.html
 2020-12-13 15:45:45 +01:00
Henrik Lissner
d2f7999c29
Don't close treemacs on ESC #1970 2020-07-29 14:30:09 -04:00
Henrik Lissner
b8a8ca9b06
Consider any window with no-other-window a popup 
This allows +popup/other (other-popup) to jump to side windows created
outside of Doom's popup manager (e.g. treemacs or neotree).
 2020-07-25 17:50:27 -04:00
Henrik Lissner
0904ee406f
Make +popup/diagnose output result 
Rather than succeed silently.
 2020-05-03 16:31:06 -04:00
Mingwei Zhang
9af8786e25
minor documentation spelling fix 
`more tha one` -> `more than one`
 2020-02-29 12:14:17 -08:00
Henrik Lissner
4fe24df90f
Fix #1970: don't count treemacs as a "popup" 
And remove its popup rule.

It isn't being caught by the popup system in the first place, so this is
all a charade.
 2020-01-06 03:50:48 -05:00
Henrik Lissner
adc8cba14b
Revise docstrings & minor reformatting 2019-12-26 01:41:44 -05:00
Henrik Lissner
6ac04e5a6d
ui/popup: prevent infinite loop when killing popup buffers 2019-12-22 16:02:56 -05:00
Ralf Beckmann
7f06644490 Make +pop/raise return the current window 2019-12-17 21:14:35 +01:00
Henrik Lissner
bcdb9f583a
Require origin argument 
If it doesn't satisfy windowp, it'll cause errors.
 2019-12-03 20:00:38 -05:00
Henrik Lissner
79faa02d6b
Record origin window earlier 
The selected window could change in between +popup--maybe-select-window calls.
 2019-12-03 19:59:27 -05:00
Yiming Chen
359ae77250 ui/popup: extract +popup--maybe-select-window helper function 2019-12-04 08:32:27 +08:00
Yiming Chen
ca63b0bbfc ui/popup: respect :select nil when reusing a window 
- before this change: when reusing a window, select option would get ignored
- after this change: when reusing a window, select option would be used
  just as a new popup
 2019-12-04 08:20:17 +08:00
Henrik Lissner
fb13b902b0
Minor comment/doc revision & refactors 2019-11-21 14:46:45 -05:00
Henrik Lissner
99cd52e70f
💥 Drop Emacs 25.x support 
Emacs 26.1 is Doom's new minimum supported version

Closes #2026
 2019-11-08 16:02:06 -05:00
Henrik Lissner
74cad2632b
ui/popup: use old alist use-case for set-popup-rule! 
This paradigm has been long since abandoned.
 2019-10-21 06:26:57 -04:00
Henrik Lissner
b3a0fb9fc7
ui/popup: correct docstring of set-popup-rule! 
Predicate functions take two arguments.
 2019-10-21 06:26:57 -04:00
Henrik Lissner
e7f492c400
ui/popup: fix "back to top level" issue 
The popup manager (by default) auto-kills most popup buffers after
~5s (controlled by the :ttl property). However, when backtrace buffers
are killed, it calls `top-level`. When the popup manager kills the
buffer, this causes janky cursor movement and the message "Back to top
level" to be displayed in the minibuffer.
 2019-10-20 19:57:27 -04:00
Henrik Lissner
7a1c8bd582
ui/popup: fix buffer cleanup ignoring kill-buffer-hook 2019-09-22 14:25:10 -04:00
Henrik Lissner
2de198e749
Fix +popup/raise not raising some windows 
The command now raises the popup into the previously selected window,
unless the prefix argument is used.
 2019-09-20 23:54:17 -04:00
Henrik Lissner
82ae3a73f3
def-advice!->defadvice! & conform to new advice conventions 
This commit does two things:

- Renames def-advice! to defadvice!, in the spirit of naming convenience
  macros after the function/macro they enhance or replace.
- Correct the names of advice functions to indicate visibility and
  intent. A public advice function like doom-set-jump-a is meant to be
  used elsewhere. A private one like +dired--cleanup-header-line-a
  shouldn't -- it likely won't work anywhere but the function(s) it was
  made to advise.
 2019-07-23 17:24:56 +02:00
Henrik Lissner
1c4215c187
Fix 'command not found' errors for hidden commands 2019-07-22 04:46:14 +02:00
Henrik Lissner
53d1bf6b58
Refactor +popup/other 2019-06-30 18:12:16 +02:00
Henrik Lissner
9a02bd8ac8
Minor refactors across the board 
- when-let* -> when-let
- Fix projectile-locate-dominating-file for connected remote files
 2019-06-26 14:31:06 +02:00
Henrik Lissner
a22c035815
ui/popup: ensure existing buffers are reused 
This resolves an issue where the popup manager would open another popup
if a previous one had been raised. The popup manager now delegates to
the existing buffer if it already exists (without resizing it).
 2019-05-15 15:22:09 -04:00
Henrik Lissner
b7c02d5c0a
Half-revert ba23b63 #1349 2019-04-21 13:25:33 -04:00
Henrik Lissner
ba23b63f5c
Fix +popup/raise for consecutive popups 2019-04-09 21:20:08 -04:00
Henrik Lissner
a8532faf08
Improve set-popup-rule!'s signature 2019-03-16 23:59:51 -04:00
Henrik Lissner
adfc06f3dd
Add no-other-window in popup criteria 
This allows +popup-window-p to recognize popup windows created by
plugins (like treemacs).
 2019-02-19 01:29:03 -05:00
Henrik Lissner
93132e43c1
Fix window--display-buffer advice #1173 
Forgot to have the :filter-return advice return the window (whoops!)
 2019-02-16 01:16:09 -05:00
Henrik Lissner
c5cd97d3cc
Fix breaking change in window--display-buffer 
This change is present in later builds of Emacs 27, where
window--display-buffer no longer has a 5th argument.
 2019-02-15 19:53:15 -05:00
Henrik Lissner
4b2dbe42a5
Fix popup :slot property 
It was broken by the new split-window parameter set on popup windows.
 2019-01-08 21:49:43 -05:00
Henrik Lissner
30eaf8fd03
Fix "cannot split parent or side window" errors 
Hopefully addresses a common issue where helm actions will operate on
the wrong window (a popup, typically, which is a dedicated side window;
Emacs doesn't let you split side windows).

This comes with a side effect: trying to split a popup will cause a
non-popup window nearby to be split instead.

Popups really aren't supposed to be split (interactively) in any case.
 2019-01-08 20:38:17 -05:00
Henrik Lissner
b56639e31b
Remove deprecated set! & def-setting! macros 2019-01-05 17:48:46 -05:00
Henrik Lissner
5c14fb42e0
Add +popup/diagnose for debugging popup rules 2018-12-06 17:51:40 -05:00
Henrik Lissner
745bd3238c
Fix delete-other-windows from inside popups 
Occasionally, a window will lose its popup status, but not its special
window parameters, forcing non-popups to be treated like popups when
delete-other-windows is called.
 2018-12-06 17:45:53 -05:00
Henrik Lissner
35170cb2e0
Merge pull request #1029 from amosbird/patch-8 
Don't scan frames other than current in popup
 2018-12-03 22:18:03 -05:00
Elijah Malaby
d063fff8a1 Fixed +popup--kill-buffer visibility check 
Now it checks all frames instead of only the current one.
 2018-12-02 13:24:02 -05:00
Amos Bird
3b67338b4a
Don't scan frames other than current in popup 
This accidentally reuses windows in other frames, especially when there are multiple compliation buffers.
 2018-11-27 22:08:35 +08:00
Edwin Török
27e17ace67 Fix race condition in popup load 
When compiling everything I got this on Emacs startup:
```
Debugger entered--Lisp error: (void-variable +popup--display-buffer-alist)
  (setq +popup--old-display-buffer-alist display-buffer-alist display-buffer-alist +popup--display-buffer-alist window--sides-inhibit-check t)
  (cond (+popup-mode (add-hook 'doom-escape-hook (function +popup|close-on-escape) t) (add-hook 'doom-cleanup-hook (function +popup|cleanup-rules)) (setq +popup--old-display-buffer-alist display-buffer-alist display-buffer-alist +popup--display-buffer-alist window--sides-inhibit-check t) (let ((--dolist-tail-- +popup-window-parameters)) (while --dolist-tail-- (let ((prop (car --dolist-tail--))) (setq window-persistent-parameters (cons (cons prop 'writable) window-persistent-parameters)) (setq --dolist-tail-- (cdr --dolist-tail--)))))) (t (remove-hook 'doom-escape-hook (function +popup|close-on-escape)) (remove-hook 'doom-cleanup-hook (function +popup|cleanup-rules)) (setq display-buffer-alist +popup--old-display-buffer-alist window--sides-inhibit-check nil) (+popup|cleanup-rules) (let ((--dolist-tail-- +popup-window-parameters)) (while --dolist-tail-- (let ((prop (car --dolist-tail--))) (delq (assq prop window-persistent-parameters) window-persistent-parameters) (setq --dolist-tail-- (cdr --dolist-tail--)))))))
  (let ((last-message (current-message))) (setq-default +popup-mode (if (eq arg 'toggle) (not (default-value '+popup-mode)) (> (prefix-numeric-value arg) 0))) (cond (+popup-mode (add-hook 'doom-escape-hook (function +popup|close-on-escape) t) (add-hook 'doom-cleanup-hook (function +popup|cleanup-rules)) (setq +popup--old-display-buffer-alist display-buffer-alist display-buffer-alist +popup--display-buffer-alist window--sides-inhibit-check t) (let ((--dolist-tail-- +popup-window-parameters)) (while --dolist-tail-- (let ((prop (car --dolist-tail--))) (setq window-persistent-parameters (cons (cons prop 'writable) window-persistent-parameters)) (setq --dolist-tail-- (cdr --dolist-tail--)))))) (t (remove-hook 'doom-escape-hook (function +popup|close-on-escape)) (remove-hook 'doom-cleanup-hook (function +popup|cleanup-rules)) (setq display-buffer-alist +popup--old-display-buffer-alist window--sides-inhibit-check nil) (+popup|cleanup-rules) (let ((--dolist-tail-- +popup-window-parameters)) (while --dolist-tail-- (let ((prop (car --dolist-tail--))) (delq (assq prop window-persistent-parameters) window-persistent-parameters) (setq --dolist-tail-- (cdr --dolist-tail--))))))) (run-hooks '+popup-mode-hook (if (default-value '+popup-mode) '+popup-mode-on-hook '+popup-mode-off-hook)) (if (called-interactively-p 'any) (progn (customize-mark-as-set '+popup-mode) (if (and (current-message) (not (equal last-message (current-message)))) nil (let ((local "")) (message "+Popup mode %sabled%s" (if (default-value '+popup-mode) "en" "dis") local))))))
  +popup-mode()
  doom-try-run-hook(+popup-mode)
  run-hook-wrapped(doom-try-run-hook +popup-mode)
  doom|init-ui()
  run-hooks(emacs-startup-hook term-setup-hook)
  #f(compiled-function () #<bytecode 0x46c615>)()
  normal-top-level()
```

Signed-off-by: Edwin Török <edwin@etorok.net>
 2018-09-19 21:43:56 +01:00
Henrik Lissner
0b350f6ea4
ui/popup: refactor +popup/raise 
Improves its error tolerance and gives it a window argument.
 2018-09-09 09:58:22 -04:00
Henrik Lissner
7d3ffdff06
Remove third line in section headers 
This is truly important stuff. We've saved many lives with this update.
 2018-09-09 09:58:19 -04:00