The vast majority of Doom modules have their defadvice! statements in
their config.el files, and not their autoloads. Since these don't need
to be autoloaded to function, we move them for better consistency.
Temporarily disable embark actions (and as a result, marginalia
annotations) for +vertico/find-file-in and functions that use it, since
because currently the embark actions don't inherit the intended
default-directory, embark actions might run unintentional destructive
operations if there are files with the same name in the
default-directory and the directory +vertico/find-file-in is run on.
Ref #5494
BREAKING CHANGE: remove +vertico/(next|previous)-candidate-preview.
BREAKING CHANGE: Move vertico-(next|previous)-group to C-M-j/k now that
C-S-j/k now default back to scrolling up and down pages.
Update docs to reflect these changes.
Switch from the homemade +vertico/backward-updir to the upstream
vertico-directory-delete-char. The former has the nice feature of
traversing up abbreviated paths, but this comes at the cost of not being
able to fully erase the path (since the buck stops at /), and
unintentional directory moving in commands such as +vertico/find-file-in
which causes issues. Overall this minor convenience is not worth it, so
the vertico-directory-delete-char behaviour of just deleting up to the
previous / is preferred instead.
- use new variable +vertico/embark-doom-package-map instead of
overriding embark-package-map
- define it with embark-define-keymap in order to inherit from the
default keymap
- move the setq to the embark use-package where it belongs
- also set which-key-use-C-h-commands to nil, otherwise sometimes
which-key will override the prefix-help-command setting
Turning on `recentf-mode` in a `cmd!` (introduced in 97048e2) means that
the `consult-customize` that turns off the previews doesn't work. This
is fixed by advising the function instead.
+ Rename +vertico--embark-target-package to
+vertico-embark-target-package-fn to conform to naming conventions,
and because it's not a private function anymore.
+ Fix +vertico-embark-target-package-fn's indentation.
Fix#5208
- unify `map!` statements when possible
- rename `+vertico--embark-target-package!` to
`+vertico--embark-target-package` and autoload it
- set `completion-in-region-function` to a wrapper function instead of
changing it with a hook
- use `:override` advice instead of `fset` for `multi-occur`
- document what `vertico-directory-tidy` does
- move `:init` contents to `:config` when possible
- Rename module from `:completion selectrum` to `:completion vertico`
- Rename all files involved
- Do *not* yet rename all the functions, as that messes up git's rename
detection.
2021-07-25 02:51:15 +03:00
Renamed from modules/completion/selectrum/config.el (Browse further)