Commit graph

31 commits

Author SHA1 Message Date
Antonio Ruiz
6fc1aa9c62 feat(rss): only call elfeed if necessary
If our *rss* workspace is already populated by elfeed buffers, there is
no reason to re-initialize elfeed.
2022-09-21 01:05:34 +02:00
Henrik Lissner
ad6a3d0f33
refactor: deprecate featurep! for modulep!
featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.

featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.
2022-08-14 20:43:35 +02:00
Henrik Lissner
e4a1e4c909
fix(rss): *rss* workspace doesn't exist error
Co-authored-by: Johnson Liu <buyandrep@gmail.com>
2022-07-04 21:51:46 +02:00
Henrik Lissner
f350a28db2
revert: fix(rss): fix *rss* workspace doesn't exist
Removed by request.

Ref: #6422
Revert: f178eb6f52
2022-06-20 16:11:02 +02:00
Johnson Liu W
f178eb6f52 fix(rss): fix *rss* workspace doesn't exist
Change-Id: Ic42528fcda679ff3538db2fad4c7d4dae6fc8d7a
2022-06-18 17:18:51 +02:00
Daniel Levy Moreno
85b16f2f48
refactor(rss): factor out hardcoded workspace name 2022-01-30 20:43:07 +01:00
Jeetaditya Chatterjee
c7753adbb3 tweak(rss): use asterisk around workspace name
This is to make it conform to the convention that all other app
workspaces conform to (plus it was bugging me)
2022-01-15 21:14:55 +01:00
Jeetaditya Chatterjee
279a897862 feat(rss): add +rss/copy-link command
Add the copy link function and bind it to `gc` as a way to draw similar
comparisons to `go` which takes the entry link and sends it to the
browser
2021-09-27 14:43:08 +01:00
Diego Alvarez
50131ac995
Add workspace support to rss/elfeed
I basically looked at the calendar app and copy/pasted the code into the rss app.

I tested it on my machine and it worked.
2020-12-15 15:42:30 -08:00
Henrik Lissner
d12752324a
Introduce letf! convenience macro
A more succinct cl-letf, which allows for local functions and macros.
2020-04-29 23:48:21 -04:00
Henrik Lissner
bc025adc19
Remove reference to removed +rss-elfeed-files var 2020-03-01 12:19:44 -05:00
Henrik Lissner
c795a988e6
Conform many modules to new conventions 2019-07-23 12:30:47 +02:00
Henrik Lissner
9a02bd8ac8
Minor refactors across the board
- when-let* -> when-let
- Fix projectile-locate-dominating-file for connected remote files
2019-06-26 14:31:06 +02:00
Henrik Lissner
ca32f7b7d1
app/rss: improve entry readability
By not using variable-pitch fonts in the SHR-converted output and
allowing images to be larger than 60% of the window's width.

Also corrects the docstring for +rss|elfeed-wrap, promising to use
`visual-fill-column-mode` when it doesn't (and never did).

Also changes `=rss` to an alias.
2019-04-02 15:47:09 -04:00
Henrik Lissner
99aefd6e02
Disable projectile cache during elfeed-db-compact 2019-03-29 03:52:24 -04:00
Henrik Lissner
7d3ffdff06
Remove third line in section headers
This is truly important stuff. We've saved many lives with this update.
2018-09-09 09:58:19 -04:00
Henrik Lissner
f52008873e
Refactor app/rss & improve kill-buffer process 2018-06-29 15:08:06 +02:00
Henrik Lissner
1a923441ff
Fix infinite-recursion when killing elfeed buffers 2018-06-29 14:12:50 +02:00
Henrik Lissner
6693db48af
Mark +org-dir obsolete (use org-directory instead)
I prefer not to invent new variables when they aren't strictly
necessary. org-directory is one such variable (although the other path
variables are still necessary).
2018-06-15 01:05:22 +02:00
Henrik Lissner
32a2a2b64d
General, minor refactor
+ Group hooks with add-hook!
+ Sharpquote elfeed call
+ Extract elfeed buffer detector into function and ensure idempotency of
  doom-real-buffer-functions
2018-06-03 15:51:59 +02:00
Henrik Lissner
8f847682fa app/rss: fix invalid window errors #646
The popup system cleans up after closed popup windows, so a
delete-window following a kill-buffer will operate on a dead window,
causing this error.
2018-06-02 18:20:09 +02:00
Henrik Lissner
8240771846
app/rss: fix +rss/quit & compact db 2018-02-17 04:55:35 -05:00
Henrik Lissner
b681917082
Remove/replace references to doom-popup-buffer 2018-01-06 03:27:23 -05:00
Henrik Lissner
22a721fd15
app/rss: fix doom-popup-buffer call #288 2017-12-10 23:35:18 -05:00
Henrik Lissner
76a4ae459d
Fix obsolete (when|if)-let messages in Emacs 26 2017-12-10 14:49:52 -05:00
Henrik Lissner
c7254e7bdc
Major optimization refactor, across the board
+ enable lexical-scope everywhere (lexical-binding = t): ~5-10% faster
  startup; ~5-20% general boost
+ reduce consing, function calls & garbage collection by preferring
  cl-loop & dolist over lambda closures (for mapc[ar], add-hook, and
  various cl-lib filter/map/reduce functions) -- where possible
+ prefer functions with dedicated opcodes, like assq (see byte-defop's
  in bytecomp.el for more)
+ prefer pcase & cond (faster) over cl-case
+ general refactor for code readability
+ ensure naming & style conventions are adhered to
+ appease byte-compiler by marking unused variables with underscore
+ defer minor mode activation to after-init, emacs-startup or
  window-setup hooks; a customization opportunity for users + ensures
  custom functionality won't interfere with startup.
2017-06-09 00:47:45 +02:00
Henrik Lissner
af3b6ee7e0 app/rss: revise maps & popup rules 2017-05-14 10:12:41 +02:00
Henrik Lissner
813630fc56 app/rss: add +rss/quit command 2017-04-10 15:54:54 -04:00
Henrik Lissner
c14a61946b app/rss: don't hide mode-line in listing window + make =rss less opinionated 2017-04-08 01:31:09 -04:00
Henrik Lissner
dd8aa48887 app/rss: add +rss-dead-feeds function 2017-04-05 15:05:40 -04:00
Henrik Lissner
ca8b3b18fa Add modules/app/rss (WIP) 2017-03-06 22:01:37 -05:00