featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.
featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.
Some of our comments/docs can come off as disparaging or snide. They're
glimpses of unfiltered frustration or snarky rubber ducking gone too
far, something I can totally sympathize with, as a scatterbrained
tinkerer, unwittingly made responsible for a lot of work that isn't mine
because of Doom's position as a middleman. But now that Doom has a
veritable userbase, I'd like to hold it to a higher standard.
Light-hearted banter and aired grievances in our source code,
documentation, or community are fine if focused on the problem or the
personal/shared experiences of the community (things that offer value or
amusement to others), but it is never acceptable to attack people or
their efforts. Especially not the very people on whose shoulders Doom
stands.
I sincerely apologize if these have offended you.
Amend: b07614037f
I've omitted docs/*.org from this merge, as there is still work left to
do there, but I am pushing the module docs early so folks can benefit
from the new docs sooner.
+notmuch/update would create an additional window that outlasts the
update process. Instead, delete the window and bury the buffer, so that
it may be read later.
Thanks to some combination of ignorance and obstinance, mu4e has thrown
compatibility to the wind and completely ignored the exitance of
define-obsolete-function-alias. Coupled with the inconsistent/partial
function renaming, this has made the mu4e 1.6⟶1.8 change particularly
annoying to deal with.
By suffering the pain of doing the mu4e author's work for them, we can
use defalias to give backwards compatibility a good shot for about 60
functions. Some mu4e~x functions are now mu4e--x, others are unchanged,
and then you've got a few odd changes like mu4e~proc -> mu4e--server and
mu4e-search-rerun. The form of message :from entries has also changed,
and a new (mu4e) entrypoint added supplanting mu4e~start.
Fix: #6511Close: #6549
Co-authored-by: Rahguzar <aikrahguzar@gmail.com>
Messages from the current day do not fit with the current width since
they are formatted as times (Ex: "05:17:23 PM"). The increase to 12
matches the mu4e defaults.
Amend: d1ba626a2a
Fewer links means less confusion.
- Merge doom-issue and doom-commit links into doom-ref (for auto-linking
Issue/PR/commit references).
- Merge doom-module-source and doom-docs-source links into doom-source.
- Rename doom-report-issue to doom-report.
- Use '!' as the icon for module issues link.
- Remove doom-repo (replaced with "doom:*" in :lang org module).
- Add doomdir and emacsdir links to :lang org module.
Adding 'Flagged messages' to mu4e-bookmarks with attributes results in
mu4e loading failure. Change the line not to use attributes.
error in process filter: mu4e-error: [mu4e] Invalid bookmark in
mu4e-bookmarks error in process filter: [mu4e] Invalid bookmark in
mu4e-bookmarks
Notmuch, like org, uses git describe to build a version string variable
at install time, but Doom preforms shallow clones of its packages, where
git describe does not work.
Notmuch is one of our bigger packages and the variable isn't essential
for normal use, so I've opted to build notmuch-version.el by hand. It
lacks the commit offset, but it has enough information to work with.
Fix#5581
At some point in the original PR alerts stopped working. I've finally
tracked down why and found three components to the problem:
- I'm calling `start-process` incorrectly
- `truncate-string-to-width` is called on `nil` when no from name is
given
- mu4e-alert uses :docid to check for duplicates, which is not provided
in mu 1.6, and so :message-id must be used instead.
Because Outlook interprets 90ch as 90px ... nice job Outlook.
I also adjusted text size and padding with code snippets while we're
tweaking.
Close#5439
We couldn't write a popup rule for message buffers because they were
named *X*, where X was the email's subject line. There was no distinct
pattern to target via regex, and the buffer is display before its mode
is initialized, so a more sophisticated popup rule wouldn't work either.
By renaming message buffers *subject:X*, we now have a chance to target
it.
Due to notmuch abusing the completing-read-multiple api,
notmuch-read-tags-changes errors out without this fix. A bug report has
been filed about this upstream, so hopefully this is a strictly
temporary measure.
Ref https://yhetil.org/notmuch/87h7efuv6i.fsf@tethera.net/T/
Ref minad/vertico#119
Notmuch sync process is done asynchronously, but if the user switch to
other buffer before update process, it complains like
```
error in process sentinel: #<window 98> is not a valid window
```
This commit simplifies cleanup process after mail syncing, and still
maintain its functionality.
