featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.
featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.
Doom changes user-emacs-directory (see 46844b5 for explanation), so
doom-emacs-dir should be used to refer to your $EMACSDIR instead.
Fix: #6530
Ref: 46844b55de
...Rather than current directory.
While +default/search-project-for-symbol-at-point should operate out of
the current project's root, +default/search-notes-for-symbol-at-point
must operate out of org-directory, and no where else, even if
org-directory is not a valid project. 411ed0c8f8 was written to fix
that, but it indirectly broke
'+default/search-project-for-symbol-at-point' (causing it to always
resolve to the current directory, rather than the current project's
root).
Amend: 411ed0c8f8Fix: #5831
Commands that delegate to `+default/search-project-for-symbol-at-point`
to search a directory (like +default/org-notes-search) would not scope
searches to default-directory.
Since multi-line inputs are useless to consult-line and swiper, I've
changed +default/search-buffer to be more DWIM (do-what-I-mean). i.e. if
a selection is active when invoking it, and...
- The selection is multi-line: restrict the search to that region.
- The selection is *not* multi-line: use the selection as the initial
input.
- Otherwise, search the whole buffer as normal.
+default/search-buffer now correctly uses the active selection when
invoking `consult-line` (on 'SPC s s' or 'SPC s b').
Close#5406
Co-authored-by: Sævar Berg <saevarb@users.noreply.github.com>
- Rename module from `:completion selectrum` to `:completion vertico`
- Rename all files involved
- Do *not* yet rename all the functions, as that messes up git's rename
detection.
- add missing emacs bindings
- properly feature guard swiper related bindings
- for selectrum, unbind `SPC s B` and temporarily bind `SPC s s` to
isearch to prevent don't get errors until we decide what to do there.
- update readme to reflect that
other +default/search-... convenience methods already support
Selectrum explicitly, so perhaps there's a good reason not to
do the same for +default/search-project-for-symbol-at-point?
The prefix arg for +default/search-project is intended to enable the
user to pick search location, however when it propagates to the ivy
search function it turns on the "search ignored files" functionality,
which us typically not intended and, furthermore, can be (if desired)
turned on simply by typing the search command in, for exampe,
counsel-rg's case as `-uu -- mysearchterm`
Affects doom/browse-in-other-project, doom/find-file-in-other-project,
+default/search-other-project and
+default/search-project-for-symbol-at-point.
When performing a text or file search in "another project", prior to
this update the current project would be the first highlighted
candidate, which doesn't make much sense when you're invoking a command
for searching *other* projects.
