Redundant with tramp-container, which is used in Emacs 29 and newer.
Ref: #6986
Amend: d41cf4e518
Co-authored-by: elken <elken@users.noreply.github.com>
BREAKING CHANGE: This command is obsolete since 0.20; consult-apropos
has been deprecated in favor of Embark actions: M-x describe-symbol
<regexp> M-x embark-export M-x describe-symbol <regexp> M-x embark-act a
BREAKING CHANGE: remove override of multi-occur with consult-multi-occur
`consult-mulit-occur` is deprecated, and although it does have the
replacement `consult-line-multi`, I don't think that this override makes
much sense, as doom doesn't really touch `multi-occur` anywhere and this
would mostly be suprising to users that do use it.
BREAKING CHANGE: That function is only meant to be used in
the *Completions* buffer, which is only relevant if you're using embark
and consult without vertico. While it doesn't hurt, it's mostly unclear
why it's there in the first place when reading the modules
featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.
featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.
The precise semantics of use-package's :after keyword is janky (see
jwiegley/use-package#829) and, in the case of 992bd8f7e2, causes
subtle breakage. For one, the remappings in the following :init block
were deferred until embark loaded, so they weren't available at startup,
so they reverted to their old (often vastly inferior) predecessors, like
recentf-open-files instead of consult-recent-files.
Amend: 992bd8f7e2
Currently, embark-consult bindings don't get loaded if consult hasn't
been loaded yet, leading to missing embark actions until the first
manual consult load.
Corfu makes completion-in-region-function a local variable in buffers
where it is enabled, so when this form is evaluated in one of those said
buffers (such as opening a file with Emacs before accessing the
minibuffer), completion-in-region-function will just be set locally
there.
BREAKING CHANGE: `embark-collect-snapshot` has been renamed upstream to
`embark-collect`. Since the `C-s` mnemonic doesn't really make sense
anymore, I've moved the binding to `C-c C-l`, which has the nice bonus
of being next to the similar `C-c C-;`, and being nicer.
The C-c C-s binding mirrors the export and writable export bindings.
embark-export is used for type specific exports (such as buffers to an
ibuffer buffer), not for verbatim exports. This is most noticeable if
you want to export a variable list, which gets you to an apropos buffer.
if you just want a list of things to keep around,
embark-collect-snapshot is the tool for the job, but having it be only
on C-; S makes it harder to reach and less visible. C-c C-s is a nice
visible thing to have around.
BREAKING CHANGE: This commit changes the behaviour of the TAB and RET
keys in a consult-completing read multiple session, in order to make
them more intuitive. The behaviour is now:
- TAB: (unchanged) always select or deselect the current candidate, and
if the candidate is selected, move the index to the next one (this
allows for pressing TAB repeatedly to select multiple subsequent
candidates).
- RET: If no candidates have been selected, select the current candidate
and exit the completion session. If some have been selected, disregard
the current candidate and exit.
- S-TAB: (new) like TAB, but the keeps the input.
The vast majority of Doom modules have their defadvice! statements in
their config.el files, and not their autoloads. Since these don't need
to be autoloaded to function, we move them for better consistency.
Temporarily disable embark actions (and as a result, marginalia
annotations) for +vertico/find-file-in and functions that use it, since
because currently the embark actions don't inherit the intended
default-directory, embark actions might run unintentional destructive
operations if there are files with the same name in the
default-directory and the directory +vertico/find-file-in is run on.
Ref #5494
BREAKING CHANGE: remove +vertico/(next|previous)-candidate-preview.
BREAKING CHANGE: Move vertico-(next|previous)-group to C-M-j/k now that
C-S-j/k now default back to scrolling up and down pages.
Update docs to reflect these changes.
Switch from the homemade +vertico/backward-updir to the upstream
vertico-directory-delete-char. The former has the nice feature of
traversing up abbreviated paths, but this comes at the cost of not being
able to fully erase the path (since the buck stops at /), and
unintentional directory moving in commands such as +vertico/find-file-in
which causes issues. Overall this minor convenience is not worth it, so
the vertico-directory-delete-char behaviour of just deleting up to the
previous / is preferred instead.
- use new variable +vertico/embark-doom-package-map instead of
overriding embark-package-map
- define it with embark-define-keymap in order to inherit from the
default keymap
