Commit graph

5071 commits

Author SHA1 Message Date
Henrik Lissner
b0741336d1 Throw error if git < 2.28
To prevent issues like #5096.
2021-05-25 14:16:38 -04:00
Henrik Lissner
f604ce6d01 Minor refactors & reformatting 2021-05-25 10:35:21 -04:00
Henrik Lissner
7b5baf319b Fix #5093: git version doctor check on macOS
git version's output is formatted differently on macOS (because of
course it is), so I use a more flexible check.
2021-05-25 10:35:21 -04:00
Henrik Lissner
df3c221c73 cli: don't repeat "Executing..." line on restart 2021-05-24 17:32:46 -04:00
Henrik Lissner
592116cece cli/doctor: add git and git 2.28 check
Also:
+ Refactors hard dependency checks
+ Improve warnings for 26.x and 28.x users

Mentioned in #5088
2021-05-24 14:54:33 -04:00
Henrik Lissner
ab1000c8d0 Fix #5088: failure to install straight.el 2021-05-24 14:33:12 -04:00
Henrik Lissner
7864082c30
Merge pull request #5079 from jgrey4296/develop
define-localleader-key's featurep -> featurep!
2021-05-24 13:49:07 -04:00
Henrik Lissner
6321b3a249 straight: clone --single-branch by default
And compute autoload prefixes; which assist the describe-* (and
helpful-*) libraries.
2021-05-24 13:34:24 -04:00
Henrik Lissner
e5b52e2a50 Remove "fix" for projectile + $HOME git repos
There are legitimate reasons why a user would want to treat $HOME as a
project. 'doom doctor' now complains about this case in greater detail.
I'll leave it to users to deal with this edge case.
2021-05-23 22:09:07 -04:00
Henrik Lissner
3ba364ae10 Minor refactoring across the board 2021-05-23 22:09:07 -04:00
Henrik Lissner
a8e57438dc Refactor doom-{path,file,dir,glob}
Breaking change: doom-glob would formerly return a string (if only one
match) or a list. Now it always returns a list.
2021-05-23 21:49:02 -04:00
Henrik Lissner
13f316e645 Fix packages evading native-compilation
(featurep 'nativecomp) will never return t.
2021-05-23 21:49:02 -04:00
Henrik Lissner
4b5cf7d46f bin/doom: polish output
Reduces the amount of "noise" included in bin/doom's output.

Also fixes an issue where warnings during autoloads generation would
sneak into Doom's autoloads file, producing weird void-variable errors,
like

  (void-variable . rainbow-delimiters:)
  (void-variable . diredfl:)
  (void-variable . company:)
2021-05-23 21:49:02 -04:00
Henrik Lissner
e297ca4bfe Bump :core
bbatsov/projectile@513228f -> bbatsov/projectile@35c6f98
domtronn/all-the-icons.el@7a12258 -> domtronn/all-the-icons.el@d711dc1
raxod502/straight.el@253d7db -> raxod502/straight.el@e46292d
2021-05-22 20:03:30 -04:00
Henrik Lissner
5aea22ec31 Prevent custom from writing font settings to custom.el
Otherwise it tries to write unreadable forms to custom-file, causing
invalid-read errors at startup.
2021-05-22 16:01:01 -04:00
Henrik Lissner
2a2969f3e0 org-roam-verbose = t
Its output is helpful. Let's not silence it.

But prevent output during incremental loading from hijacking the
minibuffer (likely the original reason org-roam-verbose was disabled).
2021-05-21 23:13:09 -04:00
John Grey
37df4b4ff4 define-localleader-key's featurep -> featurep! 2021-05-22 02:35:10 +01:00
Henrik Lissner
fe9d45bcf5 Add/Fix doom/{discourse,issue-tracker,report-bug}
Updated their URLs
2021-05-20 21:09:32 -04:00
Henrik Lissner
0196875d9c Remove redundant projectile-ignored-projects entries
/tmp and ~/.emacs.d/.local are already covered by our
projectile-ignored-project-function (doom-project-ignored-p).
2021-05-17 23:35:55 -04:00
Henrik Lissner
6fdaaf3ae6 Revert 3b0f23792 "Distinguish C-m from RET"
Unpredictably hijacks C-m in some cases, which is unacceptable. A better
solution is needed.
2021-05-17 22:33:22 -04:00
Henrik Lissner
1e9870e13a Refactor bin/doom
So innocuous CLI command return values don't break the post-script
written to /tmp/doom.sh.
2021-05-17 22:29:50 -04:00
Henrik Lissner
b237de5619 Fix <C-m> shadowing keypad return 2021-05-17 18:40:59 -04:00
Henrik Lissner
7c273ad173 Remove hard dependency on sp-point-in-* predicates 2021-05-16 21:22:06 -04:00
Henrik Lissner
060636966f Document :depth in add-hook! docstring 2021-05-16 21:19:30 -04:00
Henrik Lissner
fa8f73d9ed Revert b80b338b3
Causes a regression where output was written into /tmp/doom.sh,
producing errors like:

  /tmp//doom.sh: string 4: $'\E[32m✓': command not found

I'll revert this until I have a better solution.
2021-05-16 18:32:22 -04:00
Henrik Lissner
3b0f23792d Distinguish C-m from RET
But you must bind keys to "<C-m>" or [C-m] to target it.
2021-05-16 14:44:53 -04:00
Henrik Lissner
b80b338b3c doom--print: return message on success
More in line with `message's signature.
2021-05-16 14:22:06 -04:00
Henrik Lissner
69beabe287 Fix #5060: don't hash relative backup file paths
Also refactors undo-fu-session's make-hashed-file-path advise to use
make-backup-file-name-1.
2021-05-16 14:02:34 -04:00
Henrik Lissner
62c231efe6 Bump rainbow-delimiters
Fanael/rainbow-delimiters@f43d48a -> Fanael/rainbow-delimiters@d576e66

Fixes #5059: contains fix for 'void-variable . rainbow-delimiters:'
error.
2021-05-16 14:02:34 -04:00
Henrik Lissner
dee20c7585 Remove define-obsolete-*-alias fix
Packages have had enough time to catch up. Also, with 9d3742c0d these
fixes are no longer effective for packages.

Closes #4534
2021-05-15 14:09:08 -04:00
Henrik Lissner
fb89327ff2 Revert to straight's original bytecomp behavior
Half-reverts 628f0a9, which forced straight to byte-compile packages in
another Emacs session, which produced failures for packages that didn't
properly load their compile-time dependencies (e.g. macro calls).

But now, I realize that _not_ failing in those cases is worse and
produces odd byte-code issues like #1657 or invalid-function ((date
date)) errors. This doesn't guarantee a fix, but at least takes the ball
out of Doom's court, and gracefully fails to uncompiled packages, rather
than incorrect bytecode.
2021-05-15 14:09:08 -04:00
Henrik Lissner
9e5ba5fd6c Don't suppress user-error errors
Refactor doom-run-hooks warning.
2021-05-15 14:09:08 -04:00
Henrik Lissner
ff3c9777e7 Bump :tools debugger lsp
emacs-lsp/dap-mode@ae395aa -> emacs-lsp/dap-mode@49af1b8
emacs-lsp/helm-lsp@74a02f8 -> emacs-lsp/helm-lsp@c2c6974
emacs-lsp/lsp-ivy@515e597 -> emacs-lsp/lsp-ivy@4dcb635
emacs-lsp/lsp-mode@eda51c2 -> emacs-lsp/lsp-mode@3dc87f6
emacs-lsp/lsp-ui@1dbea9f -> emacs-lsp/lsp-ui@efae00e
emacs-straight/project@388ffdf -> emacs-straight/project@ef2d487
joaotavora/eglot@f930a09 -> joaotavora/eglot@b06589b
realgud/realgud-trepan-ni@6e38cf8 -> realgud/realgud-trepan-ni@0ec088e
realgud/realgud@f73c039 -> realgud/realgud@34557f8
tumashu/posframe@fff21cc -> tumashu/posframe@739d8fd
2021-05-15 14:08:21 -04:00
Henrik Lissner
6d2c6b44fa Refactor comp-effective-async-max-jobs advice
We only need this magic in CLI sessions. It's better to only use half
the CPUs in interactive sessions (if the user has enabled
comp-deferred-compilation for some reason).

Fixes #5042
2021-05-12 14:52:00 -04:00
Henrik Lissner
ce11a98b70 Alias native-comp-* on any Emacs 28+ build
Because boundp checks are too fallible as a guard.
2021-05-12 01:22:07 -04:00
Hyunggyu Jang
fef242aa34 Fix bin/doom compile error introduced by e2a11d24fd
With a commit of e2a11d24fd, when it comes to
`doom compile`, modules aren't loaded anymore, which corrupts the compiling process.

What I did is just adding the necessity parts for the doom's byte compiler.
2021-05-12 14:08:51 +09:00
Henrik Lissner
b092d79d35 Fix reference to comp-deferred-compilation-deny-list 2021-05-12 00:50:17 -04:00
Henrik Lissner
485f097297 Make native-comp-* aliases more robust
(defvaralias A B) throws an error if A is already defined. This breaks
Doom in the event that Doom's config is loaded late (e.g. with 'doom
run'), or these variables are set elsewhere (e.g. the sandbox). I didn't
want to have to do all these checks at startup, but it seems
unavoidable.

Since Doom will only support near-enough the latest commit of Emacs 28
HEAD, I will remove these fixes at the end of May, give or take a week.
2021-05-12 00:18:36 -04:00
Henrik Lissner
87d15700bd Fix #5038: sandbox redefining comp var aliases
Closes #5040
2021-05-11 21:29:54 -04:00
Henrik Lissner
54c67eb29e Fix #5038: renamed comp variables in sandbox loader 2021-05-11 19:28:18 -04:00
Henrik Lissner
6ad4f0698e Fix #4995: adapt to more renamed comp-* symbols
Two more variables were renamed upstream.
2021-05-11 19:03:18 -04:00
Henrik Lissner
4397f0123f Fix custom{,theme-}set-faces!, again
custom-theme-set-faces! depends on doom-theme's previous-theme property
being non-nil to determine if the theme has been set (and if so, apply
its changes immediately), but at startup custom-enabled-themes is empty,
so it was never non-nil.

Fixes #5009
Fixes #5000
2021-05-10 16:05:19 -04:00
Henrik Lissner
fdfd60dbad Don't call uname on Windows for doom/info
Mentioned in #5022
2021-05-10 04:46:14 -04:00
Henrik Lissner
c19b3c827d Add CODEOWNERS file
This won't be effective until the repo is moved to a github org and
these folks are given the needed permissions.
2021-05-10 04:41:13 -04:00
Henrik Lissner
5b50a57b85 Correct comments in doom-run-hook-on 2021-05-09 20:50:23 -04:00
Henrik Lissner
33e7f081a7 Restore hl-line-sticky-flag defaults
There are some modes that expect he highlight to be visible across
windows (like treemacs or mu4e). The performance benefit is negligible
anyhow.
2021-05-09 20:50:23 -04:00
Henrik Lissner
cebbd76f3d Revert to 'user theme
Trying to get 'doom to behave like 'user is too much trouble and causes
too many problems. The magic around 'user is too deeply woven into
custom.el. The whole custom.el fiasco needs to be dealt with another
way.

Fixes #5000
Fixes #5009
2021-05-09 20:50:23 -04:00
Henrik Lissner
d44c57f01a Add :defer support to add-hook! macro
See add-hook's DEPTH argument (replaces APPEND in Emacs 27+).
2021-05-09 13:06:24 -04:00
Henrik Lissner
10f9ec44a0 Revert "Convert custom-{,theme-}set-faces! to functions"
This reverts commit cab8f03a51.

Urg, they did have to be macros, otherwise arguments are evaluated
immediately. Note to self, stop committing things after midnight.

Fixes #5015
Closes #5016
2021-05-09 12:25:19 -04:00
Henrik Lissner
8f3b798620 Fix #5000: ensure 'doom always has precedence
'doom is a pseudo theme used to store internal faces and variables, and
must have the highest precedence (like the 'user theme, but without the
risk of being written to custom-file).
2021-05-09 01:23:42 -04:00