Commit graph

41 commits

Author SHA1 Message Date
Itai Y. Efrat
4f34635e04 refactor!(vertico): crm keybindings behaviour
BREAKING CHANGE: This commit changes the behaviour of the TAB and RET
keys in a consult-completing read multiple session, in order to make
them more intuitive. The behaviour is now:

- TAB: (unchanged) always select or deselect the current candidate, and
  if the candidate is selected, move the index to the next one (this
  allows for pressing TAB repeatedly to select multiple subsequent
  candidates).

- RET: If no candidates have been selected, select the current candidate
  and exit the completion session. If some have been selected, disregard
  the current candidate and exit.

- S-TAB: (new) like TAB, but the keeps the input.
2022-01-13 23:16:03 +02:00
Itai Y. Efrat
39ed5eb9ec bump: :completion vertico
minad/consult-flycheck@92b259e6a8 -> minad/consult-flycheck@0ad7e8ff15
minad/consult@57dc1adfdc -> minad/consult@85008702de
minad/marginalia@678b6528f3 -> minad/marginalia@2fb2787bc3
minad/vertico@75f33e3620 -> minad/vertico@eedcb84786
oantolin/embark@5b34b2b603 -> oantolin/embark@725794f013
oantolin/orderless@62f71c34ba -> oantolin/orderless@1ccf74ffdb

Remove +vertico-embark-vertico-indicator as it has been implemented upstream
2021-12-13 01:18:11 +01:00
Henrik Lissner
daf8d278d0 fix(lib): doom/help-search
Due to malformed ripgrep command (no whitespace between "." and extra
arguments).

Fix: #5758
2021-11-20 00:55:22 +01:00
Itai Y. Efrat
c8199c5c20 fix(vertico): remove noise from which-key indicator
Embark adds easier prefix-argument and digit-argument insertion in
embark-act, but these clog up the space in the which-key indicator

Also update the embark-become test to the new target format.
2021-11-19 00:29:51 +02:00
Itai Y. Efrat
6e629c1c53 refactor(vertico): move defadvice!'s to config.el
The vast majority of Doom modules have their defadvice! statements in
their config.el files, and not their autoloads. Since these don't need
to be autoloaded to function, we move them for better consistency.
2021-11-18 22:41:40 +02:00
Itai Y. Efrat
04e96c6faf bump: :completion vertico
iyefrat/all-the-icons-completion@9650041854 -> iyefrat/all-the-icons-completion@a0f34d68cc
minad/consult@dc6e455861 -> minad/consult@166e3b03c3
minad/marginalia@cb1d3ba604 -> minad/marginalia@fbd2f378f5
minad/vertico@0df75c0bbc -> minad/vertico@cd3c400aac
oantolin/embark@1492aefc00 -> oantolin/embark@8a0b80c6e6

Add --null to consult-ripgrep-args to comply with upstream changes to
filename detection.

Update +vertico-embark-which-key-indicator.

Fix #5494
Fix #5547
2021-10-10 10:46:14 +03:00
Itai Y. Efrat
34f76c8a75 fix(vertico): +vertico/switch-workspace-buffer
- fix a paren error in the function that caused the buffers to be sorted
  alphabetically and not by recency
- refactor the workspace buffer sources to use consult--buffer-query,
  that way we get niceties like the current buffer being last

Fix #5366
2021-09-23 14:55:58 +02:00
Itai Y. Efrat
dda5f558b2 fix(vertico): adapt to targets changing to plists
embark targets changed internally to plists a while back. This didn't
really seem to break anything but it's best to be up to date with the
upstream representation.
2021-09-23 14:55:58 +02:00
Itai Y. Efrat
a612220369 refactor!(vertico): evil minibuffer keybindings
BREAKING CHANGE: remove +vertico/(next|previous)-candidate-preview.

BREAKING CHANGE: Move vertico-(next|previous)-group to C-M-j/k now that

C-S-j/k now default back to scrolling up and down pages.

Update docs to reflect these changes.
2021-09-15 01:41:37 +03:00
Itai Y. Efrat
9241a4d709 refactor(vertico): file completion backspace
Switch from the homemade +vertico/backward-updir to the upstream
vertico-directory-delete-char. The former has the nice feature of
traversing up abbreviated paths, but this comes at the cost of not being
able to fully erase the path (since the buck stops at /), and
unintentional directory moving in commands such as +vertico/find-file-in
which causes issues. Overall this minor convenience is not worth it, so
the vertico-directory-delete-char behaviour of just deleting up to the
previous / is preferred instead.
2021-09-15 01:03:11 +03:00
Itai Y. Efrat
9d44b3510a fix(vertico): +vertico/jump-list requires consult 2021-09-15 01:03:11 +03:00
Itai Y. Efrat
f536103af6 fix(vertico): package target finder
now returns nil instead of erroring out when it can't find a paren in
the buffer

Co-authored-by: Leo Okawa Ericson <git@relevant-information.com>
2021-09-15 01:03:11 +03:00
Itai Y. Efrat
1f3ac1eb77 nit(vertico): fix whitespace 2021-09-15 01:03:11 +03:00
Itai Y. Efrat
934ad07f23 feat(vertico): add magit-status embark action 2021-09-15 01:03:11 +03:00
Itai Y. Efrat
fc163b16c9 feat(vertico): use basic completion for remotes
Close: #5313

Co-authored-by: Stefan Lendl <ste.lendl@gmail.com>
2021-09-15 01:03:11 +03:00
Itai Y. Efrat
2c431aae0e fix(vertico): +vertico/find-file-in...
allow the creation of new files if the input doesn't match any existing
ones.
2021-09-14 20:44:55 +03:00
Itai Y. Efrat
0a69ca957a refactor(vertico): rename which key indicator
rename +vertico/embark-which-key-indicator to
+vertico-embark-which-key-indicator, since it's not interactive
2021-09-14 20:38:40 +03:00
Itai Y. Efrat
26014435b2 feat(vertico): colorize vertico candidate on act 2021-09-14 20:38:40 +03:00
Itai Y. Efrat
940f66fa89 bump: :completion vertico
iyefrat/all-the-icons-completion@d1d4b2f0df -> iyefrat/all-the-icons-completion@9650041854
minad/consult@69bbd213dc -> minad/consult@105a1ac501
minad/marginalia@1123544536 -> minad/marginalia@c6ca58bea8
minad/vertico@9de6709cdd -> minad/vertico@81a4b35f8d
oantolin/embark@1a7e6b5561 -> oantolin/embark@19145d5a33
oantolin/orderless@1e84120a28 -> oantolin/orderless@1a7011ac9c

- Adapt consult async commands to new consult-x-args format instead of
  consult-x-command.
- Change regepx in +vertico-file-search to emacs instead of pcre,
  because consult switched to using only emacs regexps
- Move to new embark-indicators variable, and replace
  embark-mixed-indicator with +vertico/embark-which-key-indicator to be
  compatible with future changes
- Adapt Doom's optional usage of fd to new consult command format
2021-09-14 20:38:40 +03:00
Henrik Lissner
265e19a405 fix(vertico): +vertico/jump-list failing to jump
Prior to this fix this command would error out because of incorrect
expectations wrt consult--read's return value.
2021-08-21 03:29:13 -04:00
Daanturo
65950f3e91
feat(vertico): enable smart case for +vertico-file-search
Vanilla Emacs, Ivy, and Helm do this by default. Should be upstreamed.

Close #5322
2021-08-01 14:58:25 -04:00
Itai Y. Efrat
3af07d2500 fix(vertico): +vertico/embark-preview bug
- replace obsolete `embark-default-action` with `embark-dwim`
- add `defvar` for `embark-quiet-after-action` to fix lexical var bug
2021-07-31 10:50:00 +03:00
Itai Y. Efrat
f7863f96f0 nit(vertico): sharpquote a quoted function 2021-07-31 10:49:00 +03:00
Itai Y. Efrat
19c40901f1 fix(vertico): +vertico/find-file-in...
- require `consult` (`consult--directory-prompt` isn't autoloaded)
- set category to `'file`
2021-07-31 10:48:00 +03:00
Itai Y. Efrat
a23cb1fddf fix(vertico): consult-recent-file previews
Turning on `recentf-mode` in a `cmd!` (introduced in 97048e2) means that
the `consult-customize` that turns off the previews doesn't work. This
is fixed by advising the function instead.
2021-07-31 10:47:00 +03:00
Itai Y. Efrat
4c3c027a96 feat(vertico): better crm interface 2021-07-31 10:43:00 +03:00
Itai Y. Efrat
d6fba19586 bump: :completion vertico
minad/consult@28f9ba8 -> minad/consult@69bbd21
minad/marginalia@a3a8edb -> minad/marginalia@1123544
minad/vertico@4a90297 -> minad/vertico@9de6709
oantolin/embark@be03ce9 -> oantolin/embark@1a7e6b5
iyefrat/all-the-icons-completion@24cdb3b -> iyefrat/all-the-icons-completion@d1d4b2f

update embark indicator to new format
2021-07-31 10:41:00 +03:00
Daanturo
e71d564387 Fix +vertico-file-search when separator is used
instead of the Perl style.
`concat` can't operate on characters.
2021-07-29 09:42:42 +07:00
Henrik Lissner
a6b6b6197b fix(vertico): TAB bound to non-interactive function 2021-07-28 13:11:45 -04:00
Henrik Lissner
9d7338d4b8 fix(vertico): add +ivy/jump-list analogue
Fix 'SPC s j' for consult users.
2021-07-28 13:11:36 -04:00
Henrik Lissner
33b646826b fix(vertico): add counsel-file-jump analogue
Fix 'SPC f F' / 'C-c f F' for vertico users
2021-07-28 12:54:23 -04:00
Henrik Lissner
551e5adf81 fix(vertico): unreachable function in autoloads
+ Rename +vertico--embark-target-package to
  +vertico-embark-target-package-fn to conform to naming conventions,
  and because it's not a private function anymore.
+ Fix +vertico-embark-target-package-fn's indentation.

Fix #5208
2021-07-28 12:43:05 -04:00
Henrik Lissner
fd844ea18d fix(vertico): escape perl syntax in selection
+ Escape any special regexp characters in the active selection.
+ Change the async split character (#) to the first of %, @, !, &, or /
  that is absent in the active selection (falling back to %
  otherwise) (since consult doesn't recognize escaping for these
  characters).
2021-07-28 12:37:47 -04:00
Itai Y. Efrat
c4a2b0bb26 vertico: require embark in +vertico/embark-export-write
needed now that embark is lazy loaded
2021-07-25 19:05:52 +03:00
Itai Y. Efrat
83858fcaf9 vertico: remove +fuzzy check in +vertico-file-search
Doesn't do anything, it's a leftover from when the function was ported
from the ivy module.
2021-07-25 11:50:45 +03:00
Itai Y. Efrat
e2cd827f96 vertico: add variable to set company completion styles 2021-07-25 02:52:04 +03:00
Itai Y. Efrat
a4093e90fe vertico: fix unused lexical variable error 2021-07-25 02:52:04 +03:00
Itai Y. Efrat
3f1016753d vertico: various refactors...
- unify `map!` statements when possible
- rename `+vertico--embark-target-package!` to
  `+vertico--embark-target-package` and autoload it
- set `completion-in-region-function` to a wrapper function instead of
  changing it with a hook
- use `:override` advice instead of `fset` for `multi-occur`
- document what `vertico-directory-tidy` does
- move `:init` contents to `:config` when possible
2021-07-25 02:52:04 +03:00
Itai Y. Efrat
f8a64c8767 vertico: pass universal argument from vertico...
motion preview commands to underlying motion commands.
2021-07-25 02:52:04 +03:00
Itai Y. Efrat
a0eb4e9b65 completion/selectrum -> completion/vertico, part 3
- Rename all functions and variables in the module to reflect the
  namechange (and the irc jump function)
2021-07-25 02:52:04 +03:00
Itai Y. Efrat
24eaa1317c completion/selectrum -> completion/vertico, part 2
- Rename module from `:completion selectrum` to `:completion vertico`
- Rename all files involved
- Do *not* yet rename all the functions, as that messes up git's rename
  detection.
2021-07-25 02:51:15 +03:00