Commit graph

5085 commits

Author SHA1 Message Date
Henrik Lissner
3beff3133f dev: refactor, fix, and add rules to commit linter
- Conform commit linter to 50/72 rule
- Add linter rule for body line length; excludes the footer and lines
  with long URLs.
- Add linter rule for validating scopes are in lexical order.
- Add linter rule for validating footer refs.
  Footer references should reference one thing per line. That thing can
  be one of:
  - An URL.
  - An issue or PR reference (local or remote).
  - A 12-character commit hash (local or remote).
- Extend linter to detect new scopes for docs:
  - Commits of type 'docs' can now use these additional scopes (in
    addition to other possible scopes):
    - docs(install) -> for changes to our installation guide(s). It is
      expected for this to change so often that it has its own scope.
    - docs(X) -> where X is the basename of any org file in docs/*.org.
      e.g.
      - docs(index): ...
      - docs(modules): ...
      - docs(faq): ...
- Modify the scope checker to consider *any* parenthetical scope given
  for bump, revert, merge, module, or release commits to be invalid.
- Update bump commit linter for 12c hashes (see 3bedae38dd).
- Fix language in imperative ref linter warning.

Ref https://discourse.doomemacs.org/how2commit
Ref 3bedae38dd
2021-08-03 23:00:43 -04:00
Henrik Lissner
3bedae38dd dev: transition to 12c long hashes
In bumps, in :pin's, and in our git conventions. We have no rules for
the commit linter for it yet, though.
2021-08-02 22:07:13 -04:00
Henrik Lissner
74f72c15b3 dev: fix commit linter target and lint all commits
- Was formerly processing the internal merge commit, which never conforms
  to our conventions, but is also unrelated to the work at hand.
- Now lints the range of commits applicable to the event, and not just
  the latest commit.
2021-08-02 15:00:53 -04:00
Henrik Lissner
5df31a4895 dev: fix and refactor commit lint rules
- Fix rules that weren't working due to faulty logic.
- Revise linter messages for clarity and concision.
- Use conventional commit nomenclature: summary -> subject
- case-fold-search = nil, to ensure case sensitive searches
- Exclude bump type from length checks
2021-08-01 23:37:36 -04:00
Henrik Lissner
11a0c0cbdb dev: add linter rule for commit capitalization
Bad:  'fix(abc): Prevent freezes'
Good: 'fix(abc): prevent freezes'
2021-08-01 23:37:36 -04:00
Henrik Lissner
5d1d0fc7c9 dev: add linter rule for Refs: in commit footer
+ No colon.
+ One ref per line.

Bad:
  Refs: A B C
  Ref: X Y
  Ref: Z
Good:
  Ref A
  Ref B
  Ref C
  Ref X
  Ref Y
  Ref Z
2021-08-01 23:37:36 -04:00
NightMachinary
a6f365bb3f
fix: doom/move-this-file when directory is the target
* doom/move-this-file now supports moving directly into a directory
* applied requested changes

Close #4861
2021-08-01 15:13:52 -04:00
Henrik Lissner
3d423862d7 dev: add linter rules for module type
Recently added 'module' to our list of git commit types to represent
changes to our module list. These events are important enough to
Doom (and users) to track separately.
2021-08-01 11:43:01 -04:00
Henrik Lissner
345ff621c3 dev: link to gist for commit docs
Until the new docs are up, link to the gist.
2021-08-01 02:03:36 -04:00
Henrik Lissner
0b4e1c30b7 dev: fix commit linter
Forgot to add the new -C/--nocolor option for 'doom sync', and to load
the 'doom ci *' family.
2021-08-01 01:02:51 -04:00
Henrik Lissner
074b9eb0d1 dev: add commit linter workflow
Experimenting with an internal linter. Only trouble is, if Doom's CLI is
ever in a broken state, a contributor will have to know about
--no-verify option for git commit. This can be improved post CLI
rewrite.
2021-07-31 23:51:27 -04:00
Daanturo
bfc12b83b4 Black list XDG_SESSION_TYPE from doom-env
The variable is obsolete once we switch between "x11" and "wayland".
2021-07-30 08:14:48 +07:00
Itai Y. Efrat
ae2a63137a fix: use new commit format in doom/bumpify-diff 2021-07-28 23:57:39 +03:00
Henrik Lissner
33b646826b fix(vertico): add counsel-file-jump analogue
Fix 'SPC f F' / 'C-c f F' for vertico users
2021-07-28 12:54:23 -04:00
Henrik Lissner
93f6591faf tweak: gcmh-idle-delay = 5 -> 0.5
Reduce the chance of memory leaks by being a little more aggressive
about idle GC. This *may* be too low; time will tell.
2021-07-28 12:42:46 -04:00
Henrik Lissner
cd87cc0cc8 refactor: remove redundant org code
org-collect-keywords does the job here. No need to reinvent the wheel.
2021-07-28 12:42:22 -04:00
Henrik Lissner
dd9657d90d Fix SPC f F w/ vertico + consult
Not a perfect analogue to counsel-file-jump, but it's a start (and
better than the previous no-op).
2021-07-25 17:55:59 -04:00
Henrik Lissner
91e1eac024 Fix doom/delete-backward-word errors in minibuffer
The cause of the error is harmless, but the error itself was causing
breakage in the minibuffer.
2021-07-25 16:26:47 -04:00
Itai Y. Efrat
a0eb4e9b65 completion/selectrum -> completion/vertico, part 3
- Rename all functions and variables in the module to reflect the
  namechange (and the irc jump function)
2021-07-25 02:52:04 +03:00
Itai Y. Efrat
92586cacd4 selectrum: remove doom-project-find-file hack
This solution doesn't rely on condition evaluation order, and doesn't
contain `featurep!`'s unnecessarily.
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
49a5c51615 selectrum: fix bugs when counsel is loaded (hack)
some doom functions check the completion module with `fboundp`'s instead
of `featurep!`, and counsel can be loaded by using e.g. `lispy`. we add
temporary fixes for this by checking for selectrum stuff first, but this
should be given a more robust fix later on

also we document the selectrum PR's hacks in the TODO.org

see discussion on #5013
2021-07-25 02:50:42 +03:00
Itai Y. Efrat
26a310d04c selectrum: improve ivy parity
- add `completion-at-point` as analogue to `cousnel-company`
- fix emacs-bindings `counsel-company` binding to respect helm and selectrum
- add org jump commands `consult-org-heading` and `consult-org-agenda` bindings
- add `consult-history` as `counsel-minibuffer-history` analogue
- add support for `doom/help-search`
- update TODO.org
2021-07-25 02:50:31 +03:00
Henrik Lissner
3fb4ac2e4b
Merge pull request #5274 from Yp3rion/develop
Fix doom/help-packages to correctly print config locations
2021-07-23 16:15:31 -04:00
Henrik Lissner
8862f8694c Activate general-auto-unbind-keys post-startup
To prevent "X starts with non-prefix key Y" errors except at startup.
2021-07-13 14:34:30 -04:00
Henrik Lissner
6672ee5cf5 Simplify session persistence 2021-07-12 16:22:30 -04:00
Henrik Lissner
5c741cb65f Fix #5255: reload session after dashboard init
Otherwise, the dashboard replaces one of the buffers when reloading the
last session at startup.
2021-07-12 16:00:45 -04:00
Henrik Lissner
cbb0ce9f85 Don't log hooks
Produces a lot of logging noise, and Doom already injects context into
errors that occur in hooks.
2021-07-11 17:52:08 -04:00
Henrik Lissner
f523830a0e Don't load core-cli on doom/reload
Hopefully addresses "Device 1 is not a termcap terminal device" errors,
due to core-cli changing `debugger`. core-cli should never be loaded in
an interactive session anyway.

Possibly fixes #4849
2021-07-11 17:52:08 -04:00
Henrik Lissner
d79cea2e4c Minor refactors, reformatting, & comment revision 2021-07-11 17:52:08 -04:00
Henrik Lissner
95f40c62ab Add doom/bumpify-diff & doom/commit-bumps commands
To make bumping things easier. Use M-x doom/commit-bumps to create a
pre-filled bump commit in magit. Use M-x doom/bumpify-diff to scrape the
current buffer (assuming it's a diff buffer) and copy a bump commit
message to your clipboard.
2021-07-11 17:52:08 -04:00
Henrik Lissner
8da669adf0 Fix #5253: error if message is called with nil arg 2021-07-10 19:41:13 -04:00
Itai Y. Efrat
34fae1c01c Remove remaining Emacs27+ checks
- Remove remaining `EMACS27+` checks, since the whole codebase is
  assumed to run at version 27 or above now
- Remove `EMACS27+` definition since it's no longer needed
2021-07-10 16:03:41 +03:00
Henrik Lissner
bafb392031 Fix fonts losing properties when resized
Fixes #5182: fonts lose :weight and :slant when being resized.
Fixes #5146: fonts being remapped too eagerly.
2021-07-09 12:58:14 -04:00
Henrik Lissner
57026c4b70 Fix #5169: x-underline-at-descent-line = nil
Looks weird when line-spacing is non-zero.
2021-07-08 15:20:22 -04:00
Henrik Lissner
8ad846e15b Fix #5198: blacklist WSL_INTEROP in envvar file 2021-07-08 15:11:39 -04:00
Henrik Lissner
bd5327f9cc
Merge pull request #5235 from ErnestDong/develop
Filter directories when purging straight repos
2021-07-08 14:10:25 -04:00
Henrik Lissner
19edcb9314 Change doom-version to 3.0.0-alpha
The future is now.
2021-07-06 02:32:38 -04:00
Henrik Lissner
9198b03807 Bump :core
bbatsov/projectile@5e6fdab -> bbatsov/projectile@da08a91
domtronn/all-the-icons.el@facbde4 -> domtronn/all-the-icons.el@9d97c07
justbur/emacs-which-key@fc29864 -> justbur/emacs-which-key@27d9fec
raxod502/straight.el@915707f -> raxod502/straight.el@b45dd00
2021-07-06 02:32:38 -04:00
Henrik Lissner
044a1a5f2b Drop Emacs 26.x support
Emacs 27.x has been the stable version of Emacs for nearly a year, and
introduces a litany of bugfixes, performance, and quality-of-life
improvements that significantly reduce Doom's maintenance burden (like
XDG support, early-init.el, image manipulation without imagemagick, a
native JSON library, harfbuzz support, pdumper, and others).

With so many big changes on Doom's horizon, I like having one less (big)
thing to worry about.

Also reverts bb677cf7a (#5232) as it is no longer needed.
2021-07-06 02:31:52 -04:00
ErnestDong
8c3a83526b Filter directories when purging straight repos
in macOS there is always an annoying ".DS_Store" in straight/repos,
which breaks `doom purge`
2021-07-05 15:06:54 +08:00
Henrik Lissner
cb574f5d42 cli: show Emacs version at the start of output 2021-06-07 21:04:46 -04:00
Henrik Lissner
c34ed0d194 Fix #5146: errors when adjusting font size live 2021-06-07 21:03:37 -04:00
Henrik Lissner
b2376a847f Fix "Unrecognized switch -E" from doom/reload
The -E switch snuck in in c92f48675, but hasn't been introduced yet.
2021-06-06 20:36:55 -04:00
Henrik Lissner
c92f486750 Don't reload envvar file on doom/reload
Might address 'Device 1 not a termcap terminal device' errors
2021-06-06 11:52:49 -04:00
Henrik Lissner
a2871e68ed Warn about :size in doom-unicode-font docstring 2021-06-05 13:12:00 -04:00
Henrik Lissner
2d76bdceb8 Bump straight
raxod502/straight.el@0d9813a -> raxod502/straight.el@915707f

Includes hotfix for raxod502/straight.el#782
2021-06-04 18:39:56 -04:00
Henrik Lissner
f51968037a
Merge pull request #5127 from brorbw/develop
Fix typo doom update and replace with doom sync -u
2021-06-04 14:18:56 -04:00
Itai Y. Efrat
f9a1d80936 cli/packages: fix update output on unpinned packages
- don't print output of git command
- count commits and output log
2021-06-04 15:23:25 +03:00
Itai Y. Efrat
46c89d350e cli/packages: fix commit between pins counting
the commit counting introduced in a3df5bf prints `nil` instead of the
empty string when the repo moves from commit A to commit B where A isn't
reachable from B
2021-06-04 15:23:15 +03:00
Henrik Lissner
f408016c6f Rewrite how Doom scales font-size
The previous approach only resized `doom-font`. Now it resizes
`doom-variable-pitch-font` and `doom-serif-font` too, so variable-pitch,
mixed-pitch, and fixed-serif users can enjoy dynamic font scaling.
2021-06-04 02:16:31 -04:00