Commit graph

36 commits

Author SHA1 Message Date
Gerry Agbobada
8d360474ac
docs: add doctor for dev versions of Emacs
The message simply test for the "not-a-version-yet" patch number and
displays an explanation to prepare users for raised error frequency and
having a backup version of Emacs if they do not want to deal with
issues.
2021-11-20 18:32:59 +01:00
Henrik Lissner
b47440010f docs: add EMACSDIR == DOOMDIR doctor check 2021-10-11 20:25:15 +02:00
Henrik Lissner
48239aeb97 fix(cli): git version check on Windows
Of course Git on Windows produces '2.33.0.windows.2'. Why wouldn't it?
2021-09-11 14:26:45 +02:00
Itai Y. Efrat
34fae1c01c Remove remaining Emacs27+ checks
- Remove remaining `EMACS27+` checks, since the whole codebase is
  assumed to run at version 27 or above now
- Remove `EMACS27+` definition since it's no longer needed
2021-07-10 16:03:41 +03:00
Henrik Lissner
044a1a5f2b Drop Emacs 26.x support
Emacs 27.x has been the stable version of Emacs for nearly a year, and
introduces a litany of bugfixes, performance, and quality-of-life
improvements that significantly reduce Doom's maintenance burden (like
XDG support, early-init.el, image manipulation without imagemagick, a
native JSON library, harfbuzz support, pdumper, and others).

With so many big changes on Doom's horizon, I like having one less (big)
thing to worry about.

Also reverts bb677cf7a (#5232) as it is no longer needed.
2021-07-06 02:31:52 -04:00
Henrik Lissner
1a5f4afd0d Reduce minimum required git to 2.23
Thanks to raxod502/straight.el@7ca94a7, which was included in 3329448bd.
This in particular reduces the burden for Ubuntu users.

Relevant to #5088, #5096
2021-06-01 16:08:17 -04:00
Henrik Lissner
f604ce6d01 Minor refactors & reformatting 2021-05-25 10:35:21 -04:00
Henrik Lissner
7b5baf319b Fix #5093: git version doctor check on macOS
git version's output is formatted differently on macOS (because of
course it is), so I use a more flexible check.
2021-05-25 10:35:21 -04:00
Henrik Lissner
592116cece cli/doctor: add git and git 2.28 check
Also:
+ Refactors hard dependency checks
+ Improve warnings for 26.x and 28.x users

Mentioned in #5088
2021-05-24 14:54:33 -04:00
Henrik Lissner
e5b52e2a50 Remove "fix" for projectile + $HOME git repos
There are legitimate reasons why a user would want to treat $HOME as a
project. 'doom doctor' now complains about this case in greater detail.
I'll leave it to users to deal with this edge case.
2021-05-23 22:09:07 -04:00
Henrik Lissner
cf44c43f41 Simplify doctor's native JSON detection 2021-03-07 14:33:11 -05:00
Henrik Lissner
1274de3d34 Minor reformatting & refactors across the board 2021-02-25 13:59:43 -05:00
MithicSpirit
d3112b5dfc
Doom Doctor: Fix insteadOf check
Always triggers when it's correct and never triggers when it's
incorrect.
2021-01-31 13:14:19 -05:00
Henrik Lissner
026d961985 doom doctor: fix insteadOf check #2679
I got the source and destination urls mixed up.
2021-01-31 04:34:46 -05:00
Henrik Lissner
1650e25794 doom doctor: warn about insertOf rules in gitconfig
Closes #2679
2021-01-31 04:30:48 -05:00
Henrik Lissner
3f2c4b80e9
Add Emacs 26.x warning to doctor checks
We'll be dropping support for it in the next few months.
2021-01-10 05:02:00 -05:00
Henrik Lissner
8bb47f96d8
cli/doctor: fix native json detection 2020-08-12 16:01:33 -04:00
Henrik Lissner
11be796c9b
cli/doctor: warn if native JSON library is missing 2020-08-12 15:17:15 -04:00
Henrik Lissner
f7431aa7c9
Fix units of "projectile cache is too large" warning
Labeled MB, but is actually displaying KB.
2020-06-10 21:54:09 -04:00
Henrik Lissner
be889d09e8
Rename doom-format lib -> doom-output
`format` isn't an appropriate for this library, considering it (and
future additions to it) will be mainly concerned with printing or
capturing output.
2020-05-25 15:55:29 -04:00
Henrik Lissner
3a38fc633c
Change doom-{interactive,debug}-mode suffix to -p
Because these are not really modes.

Also makes `doom-debug-mode` an actual (global) minor mode.
2020-05-25 03:43:40 -04:00
Henrik Lissner
69a25a8468
Make doctor treat missing ripgrep as an error
It's a hard dependency for Doom.
2020-05-19 21:49:01 -04:00
Henrik Lissner
87e279ce61
doom/doctor: improve error handler for font detection
Fixes #3008
2020-05-15 04:59:10 -04:00
Henrik Lissner
8f8d796ecd
doom/doctor: fix 'missing emacs package: org' #2284 2020-05-15 04:19:25 -04:00
Henrik Lissner
68b5f687bd
doom/doctor: fix 'org not installed' error
Also indents missing package warnings correctly and makes them harder to
mistake for system packages.

Fixes #2284
2020-05-15 01:33:52 -04:00
Henrik Lissner
c682079783
doom/doctor: warn about 28+, not 27+
27 is now the recommended version for Doom.
2020-05-15 01:33:52 -04:00
Henrik Lissner
0e851ace9b
Backport bits of CLI rewrite
The rewrite for Doom's CLI is taking a while, so I've backported a few
important changes in order to ease the transition and fix a couple bugs
sooner.

Fixes #2802, #2737, #2386

The big highlights are:

- Fix #2802: We now update recipe repos *before* updating/installing any
  new packages. No more "Could not find package X in recipe repositories".

- Fix #2737: An edge case where straight couldn't reach a pinned
  commit (particularly with agda).

- Doom is now smarter about what option it recommends when straight
  prompts you to make a choice.

- Introduces a new init path for Doom. The old way:
  - Launch in "minimal" CLI mode in non-interactive sessions
  - Launch a "full" interactive mode otherwise.
  The new way
  - Launch in "minimal" CLI mode *only* for bin/doom
  - Launch is a simple mode for non-interactive sessions that still need
    access to your interactive config (like async org export/babel).
  - Launch a "full" interactive mode otherwise.

  This should fix compatibility issues with plugins that use the
  async.el library or spawn child Emacs processes to fake
  parallelization (like org's async export and babel functionality).

- Your private init.el is now loaded more reliably when running any
  bin/doom command. This gives you an opportunity to configure its
  settings.

- Added doom-first-{input,buffer,file}-hook hooks, which we use to queue
  deferred activation of a number of packages. Users can remove these
  modes from these hooks; altogether preventing them from loading,
  rather than waiting for them to load to then disable them,
  e.g. (after! smartparens (smartparens-global-mode -1)) -> (remove-hook
  'doom-first-buffer #'smartparens-global-mode)

  Hooks added to doom-first-*-hook variables will be removed once they
  run.

  This should also indirectly fix #2386, by preventing interactive modes
  from running in non-interactive session.

- Added `doom/bump-*` commands to make bumping modules and packages
  easier, and `doom/bumpify-*` commands for converting package!
  statements into user/repo@sha1hash format for bump commits.

- straight.el is now commit-pinned, like all other packages. We also
  more reliably install straight.el by cloning it ourselves, rather than
  relying on its bootstrap.el.

  This should prevent infinite "straight has diverged from master"
  prompts whenever we change branches (though, you might have to put up
  with it one more after this update -- see #2937 for workaround).

All the other minor changes:

- Moved core/autoload/cli.el to core/autoload/process.el
- The package manager will log attempts to check out pinned commits
- If package state is incomplete while rebuilding packages, emit a
  simpler error message instead of an obscure one!
- Added -u switch to 'doom sync' to make it run 'doom update' afterwards
- Added -p switch to 'doom sync' to make it run 'doom purge' afterwards
- Replace doom-modules function with doom-modules-list
- The `with-plist!` macro was removed, since `cl-destructuring-bind`
  already serves that purpose well enough.
- core/autoload/packages.el was moved into core-packages.el
- bin/doom will no longer die if DOOMDIR or DOOMLOCALDIR don't have a
  trailing slash
- Introduces doom-debug-variables; a list of variables to toggle on
  doom/toggle-debug-mode.
- The sandbox has been updated to reflect the above changes, also:
  1. Child instances will no longer inherit the process environment of
     the host instance,
  2. It will no longer produce an auto-save-list directory in ~/.emacs.d
2020-05-15 01:33:52 -04:00
Henrik Lissner
efee551709
doctor: check for fc-list (fontconfig)
Instead of find-font, which the doc doesn't even use.
2020-04-24 22:00:17 -04:00
Xuan Bi
09f7db43be
Be explicit about fc-list when listing fonts 2020-01-06 14:22:18 +08:00
Henrik Lissner
82c0fb6fc7
cli/doctor: ensure modules are fully loaded 2019-11-12 15:24:02 -05:00
Henrik Lissner
829e1762b1
cli/doctor: fix vestigial variable references 2019-11-10 04:56:55 -05:00
Henrik Lissner
e252ee61e7
cli/doctor: fix HOME project root detection 2019-11-10 01:39:30 -05:00
Henrik Lissner
962459e8ba
cli/doctor: fix cache filesize checks
Closes #2041
2019-11-10 01:35:21 -05:00
Henrik Lissner
6c31968a46
cli/doctor: fix font checks 2019-11-09 20:32:48 -05:00
Henrik Lissner
5c3f7d648d
cli/doctor: fix void-variable font-dest error
...when a font is missing.
2019-11-09 20:28:40 -05:00
Henrik Lissner
873fc5c0db
Rewrite core-cli
Highlights:
- 'doom purge' now purges builds, elpa packages, and repos by default.
  Regrafting repos is now opt-in with the -g/--regraft switches.
  Negation flags have been added for elpa/repos: -e/--no-elpa and
  -r/--no-repos.
- Removed 'doom rebuild' (it is now just 'doom build' or 'doom b').
- Removed 'doom build's -f flag, this is now the default. Added the -r
  flag instead, which only builds packages that need rebuilding.
- 'doom update' now updates packages synchronously, but produces more
  informative output about the updating process.
- Straight can now prompt in batch mode, which resolves a lot of issues
  with 'doom update' (and 'doom upgrade') freezing indefinitely or
  throwing repo branch errors.
- 'bin/doom's switches are now positional. Switches aimed at `bin/doom`
  must precede any subcommands. e.g.
    Do: 'doom -yd upgrade'
    Don't do: 'doom upgrade -yd'
- Moved 'doom doctor' from bin/doom-doctor to core/cli/doctor, and
  integrated core/doctor.el into it, as to avoid naming conflicts
  between it and Emacs doctor.
- The defcli! macro now has a special syntax for declaring flags, their
  arguments and descriptions.

Addresses #1981, #1925, #1816, #1721, #1322
2019-11-08 16:02:06 -05:00