We're currently discarding all evil-collection bindings on
`cider--debug-mode`. Given that `j` is bound to a particularly
disruptive and non-cancellable command, this brings some friction to
evil users.
This commit adds those bindings back under `evil +everywhere`.
The in-buffer and minibuffer displayed keybindings were adjusted to
match, but not easy-menu's.
Ref: doomemacs/doomemacs#4627
This breaks Doom in scenarios where the user has set a non-standard
doom-localleader-key, because the module is binding a localleader key
too early in the startup process.
Amend: ca90c5e83cFix: #7130
Ref: #7136
featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.
featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.
Some of our comments/docs can come off as disparaging or snide. They're
glimpses of unfiltered frustration or snarky rubber ducking gone too
far, something I can totally sympathize with, as a scatterbrained
tinkerer, unwittingly made responsible for a lot of work that isn't mine
because of Doom's position as a middleman. But now that Doom has a
veritable userbase, I'd like to hold it to a higher standard.
Light-hearted banter and aired grievances in our source code,
documentation, or community are fine if focused on the problem or the
personal/shared experiences of the community (things that offer value or
amusement to others), but it is never acceptable to attack people or
their efforts. Especially not the very people on whose shoulders Doom
stands.
I sincerely apologize if these have offended you.
Amend: b07614037f
More than a year ago a change was added to ob-clojure that prevented
evaluating a Clojure code block without setting
`org-babel-clojure-backend'. This change sets this to a default value of
CIDER, since that is the main tool used in Doom.
Without this change, manual configuration is required to use Clojure in
org babel documents.
Close#5233
* Maps cider-debug-at-point to "localleader d d"
* Overrides evil keybindings to not interfere with the cider--debug-mode
bindings during the debug session
Instead of mapping major modes to file size thresholds, it maps file
regexps (like auto-mode-alist) since the major mode cannot be known
before set-auto-mode is called (in after-find-file).
Also consolidates all REPLs (opened through the :tools eval module)
under one popup rule, which inhibits ESC from prematurely closing
them (#1944), and cleans up after their buffers *only* if their handlers
weren't specified to :persist, e.g.
(set-repl-handler! 'some-mode #'some-repl-handler :persist t)
Also standardized ESS's REPL commands.
