From fc868105cefc6ce0091fc61f0fc4d8ccb653a048 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Mon, 14 Feb 2022 17:19:19 +0100 Subject: [PATCH] fix(dired): prevent auto-revert in dired-virtual-mode dired-virtual-revert (the revert handler for dired-virtual buffers) simply errors out and prompts the user if they want to switch to a "real" dired buffer. This isn't helpful the automated nature of auto-revert, so silence it. --- modules/emacs/dired/config.el | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/modules/emacs/dired/config.el b/modules/emacs/dired/config.el index 3d3864019..d9a6aefb1 100644 --- a/modules/emacs/dired/config.el +++ b/modules/emacs/dired/config.el @@ -3,9 +3,10 @@ (use-package! dired :commands dired-jump :init - (setq dired-auto-revert-buffer (lambda (dir) (not (file-remote-p dir))) ; don't prompt to revert; just do it - dired-dwim-target t ; suggest a target for moving/copying intelligently + (setq dired-dwim-target t ; suggest a target for moving/copying intelligently dired-hide-details-hide-symlink-targets nil + ;; don't prompt to revert, just do it + dired-auto-revert-buffer #'dired-buffer-stale-p ;; Always copy/delete recursively dired-recursive-copies 'always dired-recursive-deletes 'top @@ -50,6 +51,11 @@ Fixes #3939: unsortable dired entries on Windows." ;; Don't complain about this command being disabled when we use it (put 'dired-find-alternate-file 'disabled nil) + (defadvice! +dired--no-revert-in-virtual-buffers-a (&rest args) + "Don't auto-revert in dired-virtual buffers (see `dired-virtual-revert')." + :before-while #'dired-buffer-stale-p + (not (eq revert-buffer-function #'dired-virtual-revert))) + (map! :map dired-mode-map ;; Kill all dired buffers on q :ng "q" #'+dired/quit-all