emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix setq! not triggering setters

Browse source 
Because the setters were looked up at expansion/compile time (much, much
too early), rather than at runtime.

This should indirectly fix "No year zero" errors for org-journal
users (#3173).
This commit is contained in:
Henrik Lissner 2020-05-20 01:05:27 -04:00
parent e4322fac7a
commit ecbd4b7567
No known key found for this signature in database
GPG key ID: 5F6C0EA160557395
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
core/core-lib.el
View file

@ -272,14 +272,13 @@ See `if!' for details on this macro's purpose."
(defmacro setq! (&rest settings) (defmacro setq! (&rest settings)
"A stripped-down `customize-set-variable' with the syntax of `setq'. "A stripped-down `customize-set-variable' with the syntax of `setq'.
Use this instead of `setq' when you know a variable has a custom setter (a :set This can be used as a drop-in replacement for `setq'. Particularly when you know
property in its `defcustom' declaration). This trigger setters. `setq' does a variable has a custom setter (a :set property in its `defcustom' declaration).
not." This triggers setters. `setq' does not."
(macroexp-progn (macroexp-progn
(cl-loop for (var val) on settings by 'cddr (cl-loop for (var val) on settings by 'cddr
collect (list (or (get var 'custom-set) #'set) collect `(funcall (or (get ',var 'custom-set) #'set)
(list 'quote var) ',var ,val))))
val))))
(defmacro delq! (elt list &optional fetcher) (defmacro delq! (elt list &optional fetcher)
"`delq' ELT from LIST in-place. "`delq' ELT from LIST in-place.