From ea857aa5538f7824c2fe3c6eea47cab37c777fbf Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Tue, 2 Apr 2019 18:22:01 -0400 Subject: [PATCH] feature/eval: improve REPL error handling Emit more informative error messages depending on the problem. --- modules/feature/eval/autoload/repl.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/modules/feature/eval/autoload/repl.el b/modules/feature/eval/autoload/repl.el index 5d22b47cd..58fde8c07 100644 --- a/modules/feature/eval/autoload/repl.el +++ b/modules/feature/eval/autoload/repl.el @@ -24,9 +24,12 @@ (if (commandp command) (call-interactively command) (funcall command)))) - (unless (bufferp buffer) - (error "REPL command didn't return a buffer")) - (with-current-buffer buffer (+eval-repl-mode +1)) + (cond ((null buffer) + (error "REPL handler %S couldn't open the REPL buffer" command)) + ((not (bufferp buffer)) + (error "REPL handler %S failed to return a buffer" command))) + (with-current-buffer buffer + (+eval-repl-mode +1)) (puthash key buffer +eval-repl-buffers) buffer))) (with-current-buffer buffer