emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ui/popup: fix "back to top level" issue

Browse source 
The popup manager (by default) auto-kills most popup buffers after
~5s (controlled by the :ttl property). However, when backtrace buffers
are killed, it calls `top-level`. When the popup manager kills the
buffer, this causes janky cursor movement and the message "Back to top
level" to be displayed in the minibuffer.
This commit is contained in:
Henrik Lissner 2019-10-20 13:53:09 -04:00
parent 00849c5e1b
commit e7f492c400
No known key found for this signature in database
GPG key ID: 5F6C0EA160557395
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
modules/ui/popup/autoload/popup.el
View file

@ -28,7 +28,11 @@ the buffer is visible, then set another timer and try again later."
(when-let (process (get-buffer-process buffer)) (when-let (process (get-buffer-process buffer))
(kill-process process)) (kill-process process))
(let (kill-buffer-query-functions) (let (kill-buffer-query-functions)
(kill-buffer buffer)))))))))) ;; HACK The debugger backtrace buffer, when killed, called
;; `top-level'. This causes jumpiness when the popup
;; manager tries to clean it up.
(cl-letf (((symbol-function #'top-level) #'ignore))
(kill-buffer buffer)))))))))))
(defun +popup--delete-window (window) (defun +popup--delete-window (window)
"Do housekeeping before destroying a popup window. "Do housekeeping before destroying a popup window.