From e7c21634a71acb7f75f32dbc2bd91120a0e80572 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Sun, 26 Jul 2020 14:43:19 -0400 Subject: [PATCH] Remove company-prescient Prescient re-sorts completion candidates by frecency, which is disruptive for backends that do their own sorting (like LSP or sly, or any backend that does fuzzy completion). It also slows down the presentation of candidates by at least a magnitude of 2. The net loss in performance and accuracy doesn't justify having frecency sorting, and disabling it on a per-mode basis is too big a maintenance hassle. Fix #3630 --- modules/completion/company/config.el | 8 -------- modules/completion/company/packages.el | 1 - 2 files changed, 9 deletions(-) diff --git a/modules/completion/company/config.el b/modules/completion/company/config.el index a83a13412..742bb6423 100644 --- a/modules/completion/company/config.el +++ b/modules/completion/company/config.el @@ -75,14 +75,6 @@ (add-to-list 'company-files--regexps "file:\\(\\(?:\\.\\{1,2\\}/\\|~/\\|/\\)[^\]\n]*\\)")) -(use-package! company-prescient - :hook (company-mode . company-prescient-mode) - :config - ;; NOTE prescient config duplicated with `ivy' - (setq prescient-save-file (concat doom-cache-dir "prescient-save.el")) - (prescient-persist-mode +1)) - - (use-package! company-box :when (featurep! +childframe) :hook (company-mode . company-box-mode) diff --git a/modules/completion/company/packages.el b/modules/completion/company/packages.el index b8be0ccc5..0c41f4172 100644 --- a/modules/completion/company/packages.el +++ b/modules/completion/company/packages.el @@ -3,6 +3,5 @@ (package! company :pin "1f56bec0ba7ce336eb8661b4d34e4b024d7dd04c") (package! company-dict :pin "cd7b8394f6014c57897f65d335d6b2bd65dab1f4") -(package! company-prescient :pin "b11d79b10df12c58edc3487371c2c47dfb9b50e6") (when (featurep! +childframe) (package! company-box :pin "452f083f6c11793a3723224bce42898a2bedc0e1"))