From e62f64d732eaf78093c7de24ad2227633a051c74 Mon Sep 17 00:00:00 2001
From: Henrik Lissner <henrik@lissner.net>
Date: Fri, 17 Apr 2020 22:22:10 -0400
Subject: [PATCH] Encourage +lsp for :lang go #1245

The non-LSP stack (gocode) appears to be unmaintained and is a poor
experience. Could use some help from go users to figure out which of the
dependencies in the lang/go's readme should be installed with gopls.
---
 init.example.el            | 2 +-
 modules/lang/go/README.org | 8 +++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/init.example.el b/init.example.el
index 2ffe28979..be49b185d 100644
--- a/init.example.el
+++ b/init.example.el
@@ -121,7 +121,7 @@
        ;;faust             ; dsp, but you get to keep your soul
        ;;fsharp           ; ML stands for Microsoft's Language
        ;;fstar             ; (dependent) types and (monadic) effects and Z3
-       ;;go                ; the hipster dialect
+       ;;(go +lsp)         ; the hipster dialect
        ;;(haskell +dante)  ; a language that's lazier than I am
        ;;hy                ; readability of scheme w/ speed of python
        ;;idris             ;
diff --git a/modules/lang/go/README.org b/modules/lang/go/README.org
index 04ea402fa..f16d71788 100644
--- a/modules/lang/go/README.org
+++ b/modules/lang/go/README.org
@@ -15,7 +15,8 @@
 - [[#troubleshooting][Troubleshooting]]
 
 * Description
-This module adds [[https://golang.org][Go]] support.
+This module adds [[https://golang.org][Go]] support, with optional (but recommended) LSP support via
+[[https://github.com/golang/tools/blob/master/gopls/README.md][gopls]].
 
 + Code completion (~gocode~)
 + Documentation lookup (~godoc~)
@@ -30,7 +31,8 @@ This module adds [[https://golang.org][Go]] support.
 + Code checking (~flycheck-golangci-lint~)
 
 ** Module Flags
-+ =+lsp= Enables integration for the gopls LSP server.
++ =+lsp= Enables integration for the gopls LSP server. It is highly recommended
+  you use this, as the non-LSP experience is deprecated (and poor).
 
 ** Plugins
 + [[https://github.com/dominikh/go-mode.el][go-mode]]
@@ -38,7 +40,7 @@ This module adds [[https://golang.org][Go]] support.
 + [[https://github.com/dominikh/go-mode.el][go-guru]]
 + [[https://github.com/manute/gorepl-mode][gorepl-mode]]
 + [[https://github.com/brantou/emacs-go-tag][go-tag]]
-+ [[https://github.com/mdempsky/gocode][company-go]]*
++ [[https://github.com/mdempsky/gocode][company-go]]* =DEPRECATED=
 + [[https://github.com/s-kostyaev/go-gen-test][go-gen-test]]
 + [[https://github.com/weijiangan/flycheck-golangci-lint][flycheck-golangci-lint]] (if =:checkers syntax= is enabled)