From dec2a387ad35ca1a13295b4d518c69c56a8a32a9 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Fri, 26 Jul 2024 04:42:45 -0400 Subject: [PATCH] fix(modeline): remove advice causing org-element cache errors in org This advice was suppressing ws-butler's modification hooks, which had a nasty side-effect of modifying org buffers without letting its org-element cache know that it's stale, which resulted in errors like this, followed by a backtrace: Warning (org-element): org-element--cache: Unregistered buffer modifications detected (175 != 176). Resetting. If this warning appears regularly, please report the warning text to Org mode mailing list (M-x org-submit-bug-report). The advice isn't needed anymore, anyhow. --- modules/ui/modeline/config.el | 6 ------ 1 file changed, 6 deletions(-) diff --git a/modules/ui/modeline/config.el b/modules/ui/modeline/config.el index 8aef20d7e..acd53398b 100644 --- a/modules/ui/modeline/config.el +++ b/modules/ui/modeline/config.el @@ -42,12 +42,6 @@ (doom-modeline-set-modeline 'magit) (hide-mode-line-mode)))) - ;; Some functions modify the buffer, causing the modeline to show a false - ;; modified state, so force them to behave. - (defadvice! +modeline--inhibit-modification-hooks-a (fn &rest args) - :around #'ws-butler-after-save - (with-silent-modifications (apply fn args))) - ;; ;;; Extensions