From dda81f7b54261537640e61c860148dc83643c898 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Wed, 6 Jun 2018 19:21:27 +0200 Subject: [PATCH] Fix insertion order of add-hook! when appending When appending multiple functions to a hook(s) with add-hook!, insertion order was not preserved. e.g. => (add-hook! :append 'some-mode-hook #'(hook-1 hook-2)) => some-mode-hook (hook-2 hook-1) --- core/core-lib.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/core-lib.el b/core/core-lib.el index 62afe9a6f..83b891fbd 100644 --- a/core/core-lib.el +++ b/core/core-lib.el @@ -304,7 +304,7 @@ Body forms can access the hook's arguments through the let-bound variable `(remove-hook ',hook ,fn ,local-p) `(add-hook ',hook ,fn ,append-p ,local-p)) forms))) - `(progn ,@forms)))) + `(progn ,@(if append-p (nreverse forms) forms))))) (defmacro remove-hook! (&rest args) "Convenience macro for `remove-hook'. Takes the same arguments as