From d5ecfd34296d7dce06d11792d32e5a42e0e3477f Mon Sep 17 00:00:00 2001
From: Henrik Lissner <henrik@lissner.net>
Date: Thu, 19 Sep 2019 18:42:46 -0400
Subject: [PATCH] Move pdf-tools popup rules to tools/pdf

---
 modules/tools/pdf/config.el | 5 ++---
 modules/ui/popup/+hacks.el  | 5 +----
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/modules/tools/pdf/config.el b/modules/tools/pdf/config.el
index 6d753b45f..9a0084136 100644
--- a/modules/tools/pdf/config.el
+++ b/modules/tools/pdf/config.el
@@ -41,8 +41,7 @@
   (add-hook! 'pdf-view-mode-hook (cua-mode 0))
   ;; Handle PDF-tools related popups better
   (set-popup-rule! "^\\*Outline*" :side 'right :size 40 :select nil)
-  ;; The next rules are not needed, they are defined in modules/ui/popups/+hacks.el
-  ;; (set-popup-rule! "\\*Contents\\*" :side 'right :size 40)
-  ;; (set-popup-rule! "* annots\\*$" :side 'left :size 40 :select nil)
+  (set-popup-rule! "\\(?:^\\*Contents\\|'s annots\\*$\\)" :ignore t)
+  (add-hook 'pdf-annot-list-mode-hook #'hide-mode-line-mode)
   ;; Fix #1107: flickering pdfs when evil-mode is enabled
   (setq-hook! 'pdf-view-mode-hook evil-normal-state-cursor (list nil)))
diff --git a/modules/ui/popup/+hacks.el b/modules/ui/popup/+hacks.el
index e4af5d7b0..e0b2a206a 100644
--- a/modules/ui/popup/+hacks.el
+++ b/modules/ui/popup/+hacks.el
@@ -297,10 +297,7 @@ Ugh, such an ugly hack."
         '((+popup-display-buffer-stacked-side-window-fn)
           (side . left)
           (slot . 3)
-          (inhibit-same-window . t)))
-
-  (add-hook 'pdf-annot-list-mode-hook #'hide-mode-line-mode)
-  (set-popup-rule! "\\(^\\*Contents\\|'s annots\\*$\\)" :ignore t))
+          (inhibit-same-window . t))))
 
 
 ;;;###package profiler