From ce9162647d528bfa05f04366b184383691f46cd6 Mon Sep 17 00:00:00 2001
From: Henrik Lissner <henrik@lissner.net>
Date: Wed, 2 Sep 2020 16:48:05 -0400
Subject: [PATCH] cli/env: blacklist SHLVL & comment default blacklist

---
 core/cli/env.el | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/core/cli/env.el b/core/cli/env.el
index 3856ba7ae..f8dabdef9 100644
--- a/core/cli/env.el
+++ b/core/cli/env.el
@@ -61,11 +61,14 @@ Why this over exec-path-from-shell?
 ;; Helpers
 
 (defvar doom-env-blacklist
-  '("^DBUS_SESSION_BUS_ADDRESS$"
-    "^GPG_AGENT_INFO$" "^\\(SSH\\|GPG\\)_TTY$"
-    "^SSH_\\(AUTH_SOCK\\|AGENT_PID\\)$"
-    "^HOME$" "^PWD$" "^PS1$" "^R?PROMPT$" "^TERM$"
-    ;; Doom envvars
+  '(;; State that may be problematic if overwritten
+    "^HOME$" "^\\(OLD\\)?PWD$" "^SHLVL$" "^PS1$" "^R?PROMPT$" "^TERM$" "^USER$"
+    ;; X server or services' variables
+    "^DISPLAY$" "^DBUS_SESSION_BUS_ADDRESS$"
+    ;; ssh and gpg variables (likely to become stale)
+    "^SSH_\\(AUTH_SOCK\\|AGENT_PID\\)$" "^\\(SSH\\|GPG\\)_TTY$"
+    "^GPG_AGENT_INFO$"
+    ;; Internal Doom envvars
     "^DEBUG$" "^INSECURE$" "^YES$" "^__")
   "Environment variables to not save in `doom-env-file'.