From ce27e6fa5f1235b17e0baa16e9195523ccbe480e Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Mon, 10 Oct 2016 01:23:14 +0200 Subject: [PATCH] Remove redraw calls; disruptive on Arch --- core/core-ivy.el | 2 -- core/defuns/defuns-popups.el | 17 ++++++----------- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/core/core-ivy.el b/core/core-ivy.el index b9800bd5f..10dd9e32d 100644 --- a/core/core-ivy.el +++ b/core/core-ivy.el @@ -20,8 +20,6 @@ "C-u" 'backward-kill-sentence "C-b" 'backward-word "C-f" 'forward-word) - ;; Fix display glitches - (advice-add 'ivy-done :after 'redraw-display) (after! magit (setq magit-completing-read-function 'ivy-completing-read)) (after! smex (setq smex-completion-method 'ivy)) diff --git a/core/defuns/defuns-popups.el b/core/defuns/defuns-popups.el index 444c25549..f9a0a0efa 100644 --- a/core/defuns/defuns-popups.el +++ b/core/defuns/defuns-popups.el @@ -70,7 +70,7 @@ window. Returns nil or the popup window." nil (or plist (shackle-match buffer-name))))) ;;;###autoload -(defun doom/popup-close (&optional window dont-kill dont-redraw) +(defun doom/popup-close (&optional window dont-kill) "Find and close the currently active popup (if available)." (interactive) (setq window (or window (selected-window))) @@ -85,8 +85,7 @@ window. Returns nil or the popup window." kill-buffer-query-functions))) (kill-buffer (window-buffer window))) (doom-popup-mode -1))) - (delete-window window) - (unless dont-redraw (redraw-frame)))) + (delete-window window))) ;;;###autoload (defun doom/popup-close-maybe () @@ -98,17 +97,13 @@ window. Returns nil or the popup window." (doom/popup-close))) ;;;###autoload -(defun doom/popup-close-all (&optional dont-kill dont-redraw) - "Closes all popups (kill them if DONT-KILL-BUFFERS is non-nil). Then redraw -the display (unless DONT-REDRAW is non-nil)." +(defun doom/popup-close-all (&optional dont-kill) + "Closes all popups (kill them if DONT-KILL-BUFFERS is non-nil)." (interactive) (let ((orig-win (selected-window))) (mapc (lambda (w) (doom/popup-close w dont-kill t)) - (--filter (and (doom/popup-p it) (not (eq it orig-win))) (window-list)))) - ;; Earlier versions of Emacs were more prone to graphical artifacts, so redraw - ;; the frame in them. - (when (< emacs-major-version 25) - (unless dont-redraw (redraw-frame)))) + (--filter (and (doom/popup-p it) (not (eq it orig-win))) + (window-list))))) ;;;###autoload (defun doom/popup-last-buffer ()