Appease the byte-compiler

modules/emacs/hideshow/autoload.el

@@ -2,11 +2,11 @@
 
 ;;;###autoload
 (defun +hideshow-haml-forward-sexp (arg)
-  (haml-forward-sexp)
+  (haml-forward-sexp arg)
   (move-beginning-of-line 1))
 
 ;;;###autoload
-(defun +hideshow-forward-block-by-indent (arg)
+(defun +hideshow-forward-block-by-indent (_arg)
   (let ((start (current-indentation)))
     (forward-line)
     (unless (= start (current-indentation))

modules/lang/haskell/autoload.el

@@ -1,7 +1,7 @@
 ;;; lang/haskell/autoload.el -*- lexical-binding: t; -*-
 
 ;;;###autoload
-(defun +haskell-repl-buffer ()
+(defun +haskell-repl-buffer (arg)
   "Returns the appropriate Haskell REPL buffer."
   (if (featurep! +intero)
       (intero-repl-buffer arg)
@@ -11,5 +11,5 @@
 (defun +haskell/repl (&optional arg)
   "Opens a Haskell REPL."
   (interactive "P")
-  (display-buffer (+haskell-repl-buffer)))
+  (display-buffer (+haskell-repl-buffer arg)))
 

modules/lang/latex/+ref.el

@@ -18,7 +18,7 @@
           (?t . "\\textcite[]{%l}"))
         reftex-plug-into-AUCTeX t
         reftex-toc-split-windows-fraction 0.3)
-  (unless +latex-bibtex-file
+  (when +latex-bibtex-file
     (setq reftex-default-bibliography (list (expand-file-name +latex-bibtex-file))))
   (map! :map reftex-mode-map
         :localleader :n ";" 'reftex-toc)
@@ -38,5 +38,5 @@
   (define-key bibtex-mode-map (kbd "C-c \\") #'bibtex-fill-entry))
 
 (after! bibtex-completion
-  (unless +latex-bibtex-file
+  (when +latex-bibtex-file
     (setq bibtex-completion-bibliography (list (expand-file-name +latex-bibtex-file)))))

modules/lang/org/+export.el

@@ -37,7 +37,7 @@ file isn't in `org-directory'."
     (when (and (not (nth 2 args))
                buffer-file-name
                (file-in-directory-p buffer-file-name org-directory))
-      (cl-destructuring-bind (extension &optional subtreep pubdir) args
+      (cl-destructuring-bind (extension &optional subtreep _pubdir) args
         (let ((dir (expand-file-name +org-export-dir org-directory)))
           (unless (file-directory-p dir)
             (make-directory dir t))

modules/ui/modeline/autoload/settings.el

@@ -37,7 +37,7 @@ keep them left and right aligned respectively."
        (while (keywordp (car body))
          (setq body (cddr body)))
        ;;
-       (cl-destructuring-bind (&key init faces on-hooks on-set activate deactivate &allow-other-keys)
+       (cl-destructuring-bind (&key init faces on-hooks on-set &allow-other-keys)
            rest
          (let ((realvar (if (and body faces)
                             (intern (format "+modeline--var-%s" name))

modules/ui/modeline/config.el

@@ -21,14 +21,14 @@
   "The function that returns the buffer name display for file-visiting
 buffers.")
 
+;; Convenience aliases
+(defvaralias 'mode-line-format-left '+modeline-format-left)
+(defvaralias 'mode-line-format-right '+modeline-format-right)
 ;;
 (defvar-local +modeline-format-left  () "TODO")
 (defvar-local +modeline-format-right () "TODO")
 (put '+modeline-format-left  'risky-local-variable t)
 (put '+modeline-format-right 'risky-local-variable t)
-;; Convenience aliases
-(defvaralias 'mode-line-format-left '+modeline-format-left)
-(defvaralias 'mode-line-format-right '+modeline-format-right)
 
 ;; externs
 (defvar anzu--state nil)

modules/ui/popup/+hacks.el

@@ -173,7 +173,7 @@ the command buffer."
   (set-popup-rule! "^\\*helm" :ignore t)
 
   ;; Fix left-over popup window when closing persistent help for `helm-M-x'
-  (defun +popup*helm-elisp--persistent-help (candidate fun &optional name)
+  (defun +popup*helm-elisp--persistent-help (candidate _fun &optional _name)
     (let (win)
       (when (and (helm-attr 'help-running-p)
                  (string= candidate (helm-attr 'help-current-symbol))

modules/ui/popup/autoload/popup.el

@@ -212,6 +212,7 @@ restoring it if `+popup-buffer-mode' is disabled."
       (let ((m (if (bound-and-true-p +popup-buffer-mode) +popup-margin-width)))
         (set-window-margins nil m m)))))
 
+(defvar hide-mode-line-format)
 ;;;###autoload
 (defun +popup|set-modeline-on-enable ()
   "Don't show modeline in popup windows without a `modeline' window-parameter.

modules/ui/pretty-code/autoload.el

@@ -92,7 +92,7 @@ Pretty symbols can be unset for emacs-lisp-mode with:
     (if (null (car-safe rest))
         (delq (assq mode +pretty-code-symbols-alist)
               +pretty-code-symbols-alist)
-      (let (results merge key alist)
+      (let (results merge key)
         (while rest
           (setq key (pop rest))
           (pcase key