From ca63b0bbfc1342c7192d601af847eeeb85153c3f Mon Sep 17 00:00:00 2001 From: Yiming Chen Date: Wed, 4 Dec 2019 08:20:17 +0800 Subject: [PATCH] ui/popup: respect :select nil when reusing a window - before this change: when reusing a window, select option would get ignored - after this change: when reusing a window, select option would be used just as a new popup --- modules/ui/popup/autoload/popup.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/modules/ui/popup/autoload/popup.el b/modules/ui/popup/autoload/popup.el index 5979ca636..9d93da4d4 100644 --- a/modules/ui/popup/autoload/popup.el +++ b/modules/ui/popup/autoload/popup.el @@ -189,7 +189,10 @@ and enables `+popup-buffer-mode'." (window (display-buffer-reuse-window buffer alist))) (when window (unless +popup--inhibit-select - (select-window window)) + (let ((select (+popup-parameter 'select window))) + (if (functionp select) + (funcall select window origin) + (select-window (if select window origin))))) window)) (when-let (popup (cl-loop for func in actions if (funcall func buffer alist)