From 4036f3dad1d51d68adeb7c0e2a32fd7bceb45581 Mon Sep 17 00:00:00 2001 From: UndeadKernel Date: Wed, 2 Jan 2019 15:16:05 +0100 Subject: [PATCH] pdf-tools: fixes for the new `modeline` module Sneak in a comment that addresses some TODOs. --- modules/tools/pdf/+modeline.el | 4 ++-- modules/tools/pdf/config.el | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/modules/tools/pdf/+modeline.el b/modules/tools/pdf/+modeline.el index 916886aae..f3fe0532c 100644 --- a/modules/tools/pdf/+modeline.el +++ b/modules/tools/pdf/+modeline.el @@ -6,8 +6,8 @@ (if (featurep! :ui modeline) (def-modeline-format! '+pdf - '(+mode-line-bar " " +mode-line-buffer-id " " +pdf-pages) - '(+mode-line-major-mode +mode-line-vcs)) + '(+modeline-matches " " +modeline-buffer-id " " +pdf-pages) + '(+modeline-major-mode (vc-mode (" " +modeline-vcs)))) (def-modeline! '+pdf '(bar matches " " buffer-info " " +pdf-pages) '(major-mode vcs))) diff --git a/modules/tools/pdf/config.el b/modules/tools/pdf/config.el index b4ce9e2d0..7ff08b179 100644 --- a/modules/tools/pdf/config.el +++ b/modules/tools/pdf/config.el @@ -34,8 +34,7 @@ (load! "+modeline")) ;; Handle PDF-tools related popups better (set-popup-rule! "^\\*Outline*" :side 'right :size 40 :select nil) - ;; TODO: Add additional important windows that should be handled differently - ;; TODO: These two next rules don't work (they should), investigate + ;; The next rules are not needed, they are defined in modules/ui/popups/+hacks.el ;; (set-popup-rule! "\\*Contents\\*" :side 'right :size 40) ;; (set-popup-rule! "* annots\\*$" :side 'left :size 40 :select nil) )