Major optimization refactor, across the board

+ enable lexical-scope everywhere (lexical-binding = t): ~5-10% faster
  startup; ~5-20% general boost
+ reduce consing, function calls & garbage collection by preferring
  cl-loop & dolist over lambda closures (for mapc[ar], add-hook, and
  various cl-lib filter/map/reduce functions) -- where possible
+ prefer functions with dedicated opcodes, like assq (see byte-defop's
  in bytecomp.el for more)
+ prefer pcase & cond (faster) over cl-case
+ general refactor for code readability
+ ensure naming & style conventions are adhered to
+ appease byte-compiler by marking unused variables with underscore
+ defer minor mode activation to after-init, emacs-startup or
  window-setup hooks; a customization opportunity for users + ensures
  custom functionality won't interfere with startup.

modules/tools/eshell/autoload/eshell.el

@@ -1,4 +1,4 @@
-;;; emacs/eshell/autoload/eshell.el
+;;; tools/eshell/autoload/eshell.el -*- lexical-binding: t; -*-
 
 (require 'eshell)
 
@@ -35,7 +35,7 @@ module to be loaded."
     (+eshell/run))
   (doom/workspace-display))
 
-(defun +eshell--outside-prompt-p (&optional offset)
+(defun +eshell--outside-prompt-p ()
   (< (point) eshell-last-output-end))
 
 (defun +eshell--current-git-branch ()

modules/tools/eshell/autoload/evil.el

@@ -1,7 +1,8 @@
-;;; emacs/eshell/autoload/evil.el
+;;; tools/eshell/autoload/evil.el -*- lexical-binding: t; -*-
 
 ;;;###autoload (autoload '+eshell:run "emacs/eshell/autoload/evil" nil t)
-(evil-define-command +eshell:run (command bang)
+(evil-define-command +eshell:run (_command bang)
+  ;; TODO Add COMMAND support
   (interactive "<fsh><!>")
   (if bang
       (+eshell/run)

modules/tools/eshell/config.el

@@ -1,4 +1,4 @@
-;;; emacs/eshell/config.el
+;;; tools/eshell/config.el -*- lexical-binding: t; -*-
 
 ;; This is highly experimental. I don't use eshell often, so this may need work.