Major optimization refactor, across the board

+ enable lexical-scope everywhere (lexical-binding = t): ~5-10% faster
  startup; ~5-20% general boost
+ reduce consing, function calls & garbage collection by preferring
  cl-loop & dolist over lambda closures (for mapc[ar], add-hook, and
  various cl-lib filter/map/reduce functions) -- where possible
+ prefer functions with dedicated opcodes, like assq (see byte-defop's
  in bytecomp.el for more)
+ prefer pcase & cond (faster) over cl-case
+ general refactor for code readability
+ ensure naming & style conventions are adhered to
+ appease byte-compiler by marking unused variables with underscore
+ defer minor mode activation to after-init, emacs-startup or
  window-setup hooks; a customization opportunity for users + ensures
  custom functionality won't interfere with startup.

modules/lang/javascript/+screeps.el

@@ -1,4 +1,4 @@
-;;; lang/javascript/+screeps.el
+;;; lang/javascript/+screeps.el -*- lexical-binding: t; -*-
 
 ;; TODO Constants may be out-of-date
 
@@ -171,8 +171,9 @@
   :match "/screeps/.+$"
   :modes (+javascript-npm-mode))
 
-(add-hook! '+javascript-screeps-mode-hook
+(defun +javascript|init-screeps-mode ()
   (when (eq major-mode 'js2-mode)
-    (push 'javascript-jshint flycheck-disabled-checkers)
+    (cl-pushnew 'javascript-jshint flycheck-disabled-checkers)
     (setq js2-additional-externs (append '("_") screeps-objects screeps-constants))))
+(add-hook '+javascript-screeps-mode-hook #'+javascript|init-screeps-mode)
 

modules/lang/javascript/autoload.el

@@ -1,4 +1,4 @@
-;;; lang/javascript/autoload.el
+;;; lang/javascript/autoload.el -*- lexical-binding: t; -*-
 
 (defvar +javascript-npm-conf (make-hash-table :test 'equal))
 
@@ -17,13 +17,13 @@ ignore the cache."
 ;;;###autoload
 (defun +javascript-npm-dep-p (packages &optional project-root refresh-p)
   (when-let (data (and (bound-and-true-p +javascript-npm-mode)
-                       (+javascript-npm-conf)))
+                       (+javascript-npm-conf project-root refresh-p)))
     (let ((deps (append (cdr (assq 'dependencies data))
                         (cdr (assq 'devDependencies data)))))
       (cond ((listp packages)
              (funcall (if (eq (car packages) 'and)
-                          'cl-every
-                        'cl-some)
+                          #'cl-every
+                        #'cl-some)
                       (lambda (pkg) (assq pkg deps))
                       (if (listp packages) packages (list packages))))
             ((symbolp packages)

modules/lang/javascript/config.el

@@ -1,4 +1,4 @@
-;; lang/javascript/config.el
+;;; lang/javascript/config.el -*- lexical-binding: t; -*-
 
 (load! +screeps)
 
@@ -17,12 +17,13 @@
   (add-hook! 'js2-mode-hook (setq js-switch-indent-offset js-indent-level))
 
   ;; Favor local eslint over global, if available
-  (add-hook! 'flycheck-mode-hook
+  (defun +javascript|init-flycheck-elint ()
     (when (derived-mode-p 'js-mode 'js2-mode)
       (when-let ((eslint (expand-file-name "node_modules/eslint/bin/eslint.js" (doom-project-root)))
                  (exists-p (file-exists-p eslint))
                  (executable-p (file-executable-p eslint)))
         (setq-local flycheck-javascript-eslint-executable eslint))))
+  (add-hook 'flycheck-mode-hook #'+javascript|init-flycheck-elint)
 
   (set! :repl 'js2-mode '+javascript/repl)
   (set! :electric 'js2-mode :chars '(?\} ?\) ?.))