Major optimization refactor, across the board

+ enable lexical-scope everywhere (lexical-binding = t): ~5-10% faster
  startup; ~5-20% general boost
+ reduce consing, function calls & garbage collection by preferring
  cl-loop & dolist over lambda closures (for mapc[ar], add-hook, and
  various cl-lib filter/map/reduce functions) -- where possible
+ prefer functions with dedicated opcodes, like assq (see byte-defop's
  in bytecomp.el for more)
+ prefer pcase & cond (faster) over cl-case
+ general refactor for code readability
+ ensure naming & style conventions are adhered to
+ appease byte-compiler by marking unused variables with underscore
+ defer minor mode activation to after-init, emacs-startup or
  window-setup hooks; a customization opportunity for users + ensures
  custom functionality won't interfere with startup.

modules/feature/eval/autoload/build.el

@@ -1,4 +1,4 @@
-;;; feature/eval/autoload/build.el
+;;; feature/eval/autoload/build.el -*- lexical-binding: t; -*-
 
 (defvar-local +eval-last-builder nil
   "The last builder run in the current buffer.")
@@ -22,9 +22,7 @@ functions.")
               :key 'cdr))
     (if (= (length builders) 1)
         (car builders)
-      (when-let (builder (completing-read "Build: "
-                                          (mapcar #'car builders)
-                                          nil t))
+      (when-let (builder (completing-read "Build: " (mapcar #'car builders) nil t))
         (assq (intern builder) builders)))))
 
 ;;;###autoload
@@ -36,9 +34,8 @@ functions.")
              (error "No builder for this buffer"))))
   (unless builder
     (error "Builder not found in registered builders"))
-  (let* ((name  (car builder))
-         (plist (cdr builder))
-         (fn (plist-get plist :fn)))
+  (let ((name  (car builder))
+        (fn (plist-get (cdr builder) :fn)))
     (message "Running %s" name)
     (if (or (functionp fn)
             (and (symbolp fn) (fboundp fn)))

modules/feature/eval/autoload/eval.el

@@ -1,4 +1,4 @@
-;;; feature/eval/autoload/eval.el
+;;; feature/eval/autoload/eval.el -*- lexical-binding: t; -*-
 
 ;;;###autoload
 (defun +eval/buffer ()

modules/feature/eval/autoload/evil.el

@@ -1,4 +1,4 @@
-;;; feature/eval/autoload/evil.el
+;;; feature/eval/autoload/evil.el -*- lexical-binding: t; -*-
 
 ;;;###autoload (autoload '+eval:region "feature/eval/autoload/evil" nil t)
 (evil-define-operator +eval:region (beg end)

modules/feature/eval/autoload/repl.el

@@ -1,28 +1,28 @@
-;;; feature/eval/autoload/repl.el
+;;; feature/eval/autoload/repl.el -*- lexical-binding: t; -*-
 
 (defvar +eval-repl-buffer nil
   "The buffer of the last open repl.")
 
 (defun +eval--ensure-in-repl-buffer (&optional command)
-  (if (eq (current-buffer) +eval-repl-buffer)
-      t
-    (if (and +eval-repl-buffer (buffer-live-p +eval-repl-buffer))
-        (if-let (win (get-buffer-window +eval-repl-buffer))
-            (select-window win)
-          (doom-popup-buffer +eval-repl-buffer))
-      (when command
-        (let ((repl-buffer (save-window-excursion (call-interactively command))))
-          (unless (bufferp repl-buffer)
-            (error "REPL command didn't return a buffer"))
-          (with-current-buffer repl-buffer (+eval-repl-mode +1))
-          (setq +eval-repl-buffer repl-buffer)
-          (select-window (doom-popup-buffer repl-buffer)))))
-    (when (eq (current-buffer) +eval-repl-buffer)
-      (goto-char (if (and (derived-mode-p 'comint-mode)
-                          (cdr comint-last-prompt))
-                     (cdr comint-last-prompt)
-                   (point-max)))
-      t)))
+  (or (eq (current-buffer) +eval-repl-buffer)
+      (progn
+        (if (and +eval-repl-buffer (buffer-live-p +eval-repl-buffer))
+            (if-let (win (get-buffer-window +eval-repl-buffer))
+                (select-window win)
+              (doom-popup-buffer +eval-repl-buffer))
+          (when command
+            (let ((repl-buffer (save-window-excursion (call-interactively command))))
+              (unless (bufferp repl-buffer)
+                (error "REPL command didn't return a buffer"))
+              (with-current-buffer repl-buffer (+eval-repl-mode +1))
+              (setq +eval-repl-buffer repl-buffer)
+              (select-window (doom-popup-buffer repl-buffer)))))
+        (when (eq (current-buffer) +eval-repl-buffer)
+          (goto-char (if (and (derived-mode-p 'comint-mode)
+                              (cdr comint-last-prompt))
+                         (cdr comint-last-prompt)
+                       (point-max)))
+          t))))
 
 ;;;###autoload
 (defun +eval/repl ()
@@ -31,8 +31,8 @@ the cursor at the prompt."
   (interactive)
   (when-let (command (cdr (assq major-mode +eval-repls)))
     (when (+eval--ensure-in-repl-buffer command)
-      (when (and (featurep 'evil) evil-mode)
-        (call-interactively 'evil-append-line))
+      (when (bound-and-true-p evil-mode)
+        (call-interactively #'evil-append-line))
       t)))
 
 ;;;###autoload
@@ -43,8 +43,8 @@ execute it immediately after."
   (let ((selection (buffer-substring-no-properties beg end)))
     (unless (+eval--ensure-in-repl-buffer)
       (error "No REPL open"))
-    (when (and (featurep 'evil) evil-mode)
-      (call-interactively 'evil-append-line))
+    (when (bound-and-true-p evil-mode)
+      (call-interactively #'evil-append-line))
     (insert (string-trim selection))
     (when auto-execute-p
       ;; I don't use `comint-send-input' because different REPLs may have their

modules/feature/eval/config.el

@@ -1,4 +1,4 @@
-;;; feature/eval/config.el
+;;; feature/eval/config.el -*- lexical-binding: t; -*-
 
 ;;
 ;; Code building