Major optimization refactor, across the board

+ enable lexical-scope everywhere (lexical-binding = t): ~5-10% faster
  startup; ~5-20% general boost
+ reduce consing, function calls & garbage collection by preferring
  cl-loop & dolist over lambda closures (for mapc[ar], add-hook, and
  various cl-lib filter/map/reduce functions) -- where possible
+ prefer functions with dedicated opcodes, like assq (see byte-defop's
  in bytecomp.el for more)
+ prefer pcase & cond (faster) over cl-case
+ general refactor for code readability
+ ensure naming & style conventions are adhered to
+ appease byte-compiler by marking unused variables with underscore
+ defer minor mode activation to after-init, emacs-startup or
  window-setup hooks; a customization opportunity for users + ensures
  custom functionality won't interfere with startup.

modules/completion/ido/config.el

@@ -1,7 +1,7 @@
-;;; emacs/ido/config.el
+;;; completion/ido/config.el -*- lexical-binding: t; -*-
 
 (def-package! ido
-  :init
+  :config
   (setq ido-ignore-buffers
         '("\\` " "^\\*ESS\\*" "^\\*Messages\\*" "^\\*Help\\*" "^\\*Buffer"
           "^\\*.*Completions\\*$" "^\\*Ediff" "^\\*tramp" "^\\*cvs-"
@@ -16,7 +16,6 @@
         ido-enable-last-directory-history t
         ido-save-directory-list-file (concat doom-cache-dir "ido.last"))
 
-  :config
   (push "\\`.DS_Store$" ido-ignore-files)
   (push "Icon\\?$" ido-ignore-files)
 
@@ -24,15 +23,15 @@
   (ido-everywhere 1)
   (require 'ido-ubiquitous)
 
-  (add-hook! ido-setup
+  (defun +ido|init ()
     (require 'ido-vertical-mode)
     (require 'flx-ido)
     (require 'crm-custom)
-
     (map! :map (ido-common-completion-map ido-completion-map ido-file-completion-map)
           "C-n" #'ido-next-match
           "C-p" #'ido-prev-match
           "C-w" #'ido-delete-backward-word-updir))
+  (add-hook 'ido-setup-hook #'+ido|init)
 
   (defun +ido*sort-mtime ()
     "Sort ido filelist by mtime instead of alphabetically."
@@ -43,16 +42,16 @@
                    (sixth (file-attributes (concat ido-current-directory b)))
                    (sixth (file-attributes (concat ido-current-directory a)))))))
     (ido-to-end  ;; move . files to end (again)
-     (delq nil (mapcar
-                (lambda (x) (and (char-equal (string-to-char x) ?.) x))
-                ido-temp-list))))
+     (cl-loop for x in ido-temp-list
+              if (char-equal (string-to-char x) ?.)
+              collect x)))
   (advice-add #'ido-sort-mtime :override #'+ido*sort-mtime)
   (add-hook! (ido-make-file-list ido-make-dir-list) #'+ido*sort-mtime)
 
   (defun +ido|setup-home-keybind ()
     "Go to $HOME with ~"
     (define-key ido-file-completion-map (kbd "~")
-      (λ! (if (looking-back "/")
+      (λ! (if (looking-back "/" (point-min))
              (insert "~/")
            (call-interactively #'self-insert-command)))))
   (add-hook 'ido-setup-hook #'+ido|setup-home-keybind))

modules/completion/ido/packages.el

@@ -1,5 +1,5 @@
 ;; -*- no-byte-compile: t; -*-
-;;; emacs/ido/packages.el
+;;; completion/ido/packages.el
 
 (package! flx-ido)
 (package! ido-ubiquitous)