Major optimization refactor, across the board

+ enable lexical-scope everywhere (lexical-binding = t): ~5-10% faster
  startup; ~5-20% general boost
+ reduce consing, function calls & garbage collection by preferring
  cl-loop & dolist over lambda closures (for mapc[ar], add-hook, and
  various cl-lib filter/map/reduce functions) -- where possible
+ prefer functions with dedicated opcodes, like assq (see byte-defop's
  in bytecomp.el for more)
+ prefer pcase & cond (faster) over cl-case
+ general refactor for code readability
+ ensure naming & style conventions are adhered to
+ appease byte-compiler by marking unused variables with underscore
+ defer minor mode activation to after-init, emacs-startup or
  window-setup hooks; a customization opportunity for users + ensures
  custom functionality won't interfere with startup.

modules/app/email/autoload/email.el

@@ -1,15 +1,15 @@
-;;; app/email/autoload/email.el
+;;; app/email/autoload/email.el -*- lexical-binding: t; -*-
 
 ;;;###autoload
 (defun =email ()
   "Start email client."
   (interactive)
-  (call-interactively 'mu4e))
+  (call-interactively #'mu4e))
 
 ;;;###autoload
 (defun +email/compose ()
   "Compose a new email."
   (interactive)
   ;; TODO Interactively select email account
-  (call-interactively 'mu4e-compose-new))
+  (call-interactively #'mu4e-compose-new))
 

modules/app/email/autoload/evil.el

@@ -1,4 +1,4 @@
-;;; app/email/autoload/evil.el
+;;; app/email/autoload/evil.el -*- lexical-binding: t; -*-
 
 ;;;###autoload
 (defun +email/mark (&optional beg end)
@@ -8,11 +8,12 @@
   (let* ((beg (or (and (region-active-p) evil-visual-beginning) (line-beginning-position)))
          (end (or (and (region-active-p) evil-visual-end) (line-end-position)))
          (key (this-command-keys))
-         (command (car (cl-find-if (lambda (mark) (equal (car (plist-get (cdr mark) :char)) key))
-                                   mu4e-marks))))
+         (command
+          (car (cl-find-if (lambda (mark) (equal (car (plist-get (cdr mark) :char)) key))
+                           mu4e-marks))))
     (unless command
       (error "Not a valid mark command: %s" key))
-    (when (featurep 'evil)
+    (when (bound-and-true-p evil-mode)
       (evil-normal-state))
     (goto-char beg)
     (dotimes (_ (count-lines beg end))

modules/app/email/config.el

@@ -1,4 +1,4 @@
-;;; app/email/config.el
+;;; app/email/config.el -*- lexical-binding: t; -*-
 
 ;; I want to live in Emacs. Living is incomplete without email, so Emacs needs
 ;; to give me the ability to read, search, write and send my email. It does so
@@ -16,9 +16,9 @@
 
 (def-setting! :email (label letvars &optional default)
   "Registers an email address for mu4e."
-  (let* ((name (or (cdr (assq 'user-full-name letvars)) user-full-name))
-         (address (cdr (assq 'user-mail-address letvars))))
-    (dolist (var letvars letvars)
+  (let ((name (or (cdr (assq 'user-full-name letvars)) user-full-name))
+        (address (cdr (assq 'user-mail-address letvars))))
+    (dolist (var letvars)
       (let ((val (cdr var)))
         (when (and (stringp val) (string-match-p "%s" val))
           (setcdr var (format val label)))))
@@ -96,15 +96,15 @@
                          ("mime:image/*" "Messages with images" ?p)))
 
   ;; Add a column to display what email account the email belongs to.
-  (push '(:account
-          :name "Account"
-          :shortname "Account"
-          :help "Which account this email belongs to"
-          :function
-          (lambda (msg)
-            (let ((maildir (mu4e-message-field msg :maildir)))
-              (format "%s" (substring maildir 1 (string-match-p "/" maildir 1))))))
-        mu4e-header-info-custom)
+  (cl-pushnew '(:account
+                :name "Account"
+                :shortname "Account"
+                :help "Which account this email belongs to"
+                :function
+                (lambda (msg)
+                  (let ((maildir (mu4e-message-field msg :maildir)))
+                    (format "%s" (substring maildir 1 (string-match-p "/" maildir 1))))))
+              mu4e-header-info-custom)
 
   ;; In my workflow, emails won't be moved at all. Only their flags/labels are
   ;; changed. Se we redefine the trash and refile marks not to do any moving.

modules/app/present/autoload.el

@@ -1,4 +1,4 @@
-;;; app/present/autoload.el
+;;; app/present/autoload.el -*- lexical-binding: t; -*-
 
 ;; --- impatient-mode -------------------------------------------------------------
 
@@ -14,8 +14,9 @@
     (+present--cleanup-impatient-mode)))
 
 (defun +present--cleanup-impatient-mode ()
-  (unless (cl-remove-if-not (lambda (buf) (buffer-local-value 'impatient-mode buf))
-                            (doom-buffer-list))
+  (unless (cl-loop for buf in (doom-buffer-list)
+                   if (buffer-local-value 'impatient-mode buf)
+                   return t)
     (httpd-stop)
     (remove-hook 'kill-buffer-hook '+present--cleanup-impatient-mode)))
 
@@ -60,8 +61,9 @@
     (text-scale-set +present-scale)))
 
 (defun +present--cleanup-org-tree-slides-mode ()
-  (unless (cl-remove-if-not (lambda (buf) (buffer-local-value 'org-tree-slide-mode buf))
-                            (doom-buffers-in-mode 'org-mode))
+  (unless (cl-loop for buf in (doom-buffers-in-mode 'org-mode)
+                   if (buffer-local-value 'org-tree-slide-mode buf)
+                   return t)
     (org-tree-slide-mode -1)
     (remove-hook 'kill-buffer-hook #'+present--cleanup-org-tree-slides-mode)))
 

modules/app/present/config.el

@@ -1,4 +1,4 @@
-;;; app/present/config.el
+;;; app/present/config.el -*- lexical-binding: t; -*-
 
 ;; Sometimes you just get that urge to show off. I don't have a fancy car, so
 ;; my code or Emacs will have to do.
@@ -68,7 +68,8 @@
     (add-hook! 'org-tree-slide-mode-after-narrow-hook
       #'(+present|detect-slide +present|add-overlays org-display-inline-images))
 
-    (add-hook! 'org-tree-slide-mode-hook
+    (defun +present|org-tree-present-mode ()
+      "TODO"
       (doom/window-zoom)
       (let ((arg (if org-tree-slide-mode +1 -1)))
         (centered-window-mode arg)
@@ -87,8 +88,10 @@
                (set-face-attribute 'org-level-2 nil :height 1.0)
                (+present|remove-overlays)
                (org-remove-inline-images)))))
+    (add-hook 'org-tree-slide-mode-hook #'+present|org-tree-present-mode)
 
     (defun +present*org-tree-slide-narrow-exclude-header (orig-fn &rest args)
+      "TODO"
       (cl-letf (((symbol-function 'org-narrow-to-subtree)
                  (lambda () (save-excursion
                          (save-match-data

modules/app/rss/autoload.el

@@ -1,4 +1,4 @@
-;;; app/rss/autoload.el
+;;; app/rss/autoload.el -*- lexical-binding: t; -*-
 
 ;;;###autoload
 (defun =rss ()

modules/app/rss/config.el

@@ -1,4 +1,4 @@
-;;; app/rss/config.el
+;;; app/rss/config.el -*- lexical-binding: t; -*-
 
 ;; This is an opinionated workflow that turns Emacs into an RSS reader, inspired
 ;; by apps Reeder and Readkit. It can be invoked via `=rss'. Otherwise, if you
@@ -31,8 +31,8 @@
   (make-directory elfeed-db-directory t)
 
   ;; Ensure elfeed buffers are treated as real
-  (push (lambda (buf) (string-match-p "^\\*elfeed" (buffer-name buf)))
-        doom-real-buffer-functions)
+  (cl-pushnew (lambda (buf) (string-match-p "^\\*elfeed" (buffer-name buf)))
+              doom-real-buffer-functions)
 
   ;; Enhance readability of a post
   (add-hook 'elfeed-show-mode-hook #'+rss|elfeed-wrap)

modules/app/twitter/autoload.el

@@ -1,4 +1,4 @@
-;;; app/twitter/autoload.el
+;;; app/twitter/autoload.el -*- lexical-binding: t; -*-
 
 ;;;###autoload
 (defun =twitter ()
@@ -7,7 +7,7 @@
   (delete-other-windows)
   (condition-case ex
       (progn
-        (call-interactively 'twit)
+        (call-interactively #'twit)
         (unless (get-buffer (car twittering-initial-timeline-spec-string))
           (error "Failed to open twitter"))
         (switch-to-buffer (car twittering-initial-timeline-spec-string))

modules/app/twitter/config.el

@@ -1,4 +1,4 @@
-;;; app/twitter/config.el
+;;; app/twitter/config.el -*- lexical-binding: t; -*-
 
 (def-package! twittering-mode
   :commands twit

modules/app/write/autoload.el

@@ -1,7 +1,8 @@
-;;; app/write/autoload.el
+;;; app/write/autoload.el -*- lexical-binding: t; -*-
 
 ;;;###autoload
 (define-minor-mode +write-mode
+  "TODO"
   :init-value nil
   :keymap nil
   (let ((arg  (if +write-mode +1 -1))