emacs/eshell: fix pcomplete+ivy/helm integration

Use ivy/helm instead of the popup at the bottom.

modules/emacs/eshell/autoload/eshell.el

@@ -125,6 +125,14 @@ module to be loaded."
     (insert command)
     (eshell-send-input nil t)))
 
+;;;###autoload
+(defun +eshell/pcomplete ()
+  "Use pcomplete with completion-in-region backend instead of popup window at
+bottom. This ties pcomplete into ivy or helm, if they are enabled."
+  (interactive)
+  (require 'pcomplete)
+  (pcomplete-std-complete))
+
 
 ;;
 ;; Hooks

modules/emacs/eshell/config.el

@@ -63,6 +63,7 @@ redefines its keys every time `eshell-mode' is enabled."
         "d"        #'+eshell/evil-delete
         "D"        #'+eshell/evil-delete-line)
       (evil-define-key* 'insert eshell-mode-map
+        [tab]      #'+eshell/pcomplete
         "\C-d"     #'+eshell/quit-or-delete-char
         "\C-p"     #'eshell-previous-input
         "\C-n"     #'eshell-next-input))