General minor refactor & docstring fixes

modules/app/twitter/config.el

@@ -47,9 +47,10 @@
     (bar matches " %b " selection-info)
     ())
 
-  (add-hook! twittering-mode
+  (defun +twitter|switch-mode-and-header-line ()
     (setq header-line-format (or (doom-modeline 'twitter) mode-line-format)
           mode-line-format nil))
+  (add-hook 'twittering-mode-hook #'+twitter|switch-mode-and-header-line)
 
   (map! :map twittering-mode-map
         "q"   #'+twitter/quit

modules/feature/evil/config.el

@@ -365,8 +365,8 @@ the new algorithm is confusing, like in python or ruby."
              evil-visualstar/begin-search-forward
              evil-visualstar/begin-search-backward)
   :init
-  (map! :v "*" #'evil-visualstar/begin-search-forward
-        :v "#" #'evil-visualstar/begin-search-backward)
+  (map! :m [remap evil-ex-search-word-forward]  #'evil-visualstar/begin-search-forward
+        :m [remap evil-ex-search-word-backward] #'evil-visualstar/begin-search-backward)
   :config
   (global-evil-visualstar-mode 1))
 

modules/feature/lookup/autoload/lookup.el

@@ -31,11 +31,11 @@
                                       :documentation +lookup-documentation-functions
                                       :file +lookup-file-functions)
                                 prop)
-           for fn = (or (command-remapping fn) fn)
+           for cmd = (or (command-remapping fn) fn)
            if (condition-case e
-                  (or (if (commandp fn)
-                          (call-interactively fn)
-                        (funcall fn identifier))
+                  (or (if (commandp cmd)
+                          (call-interactively cmd)
+                        (funcall cmd identifier))
                       (/= (point-marker) origin))
                 ('error (ignore (message "%s" e))))
            return it))

modules/lang/haskell/+intero.el

@@ -2,9 +2,17 @@
 ;;;###if (featurep! +intero)
 
 (def-package! intero
-  :after haskell-mode
-  :config
+  :commands intero-mode
+  :init
+  (defun +haskell|init-intero ()
+    "Initializes `intero-mode' in haskell-mode, unless stack isn't installed.
+This is necessary because `intero-mode' doesn't do its own error checks."
+    (when (derived-mode-p 'haskell-mode)
+      (if (executable-find "stack")
+          (intero-mode +1)
+        (message "Couldn't find stack. Refusing to enable intero-mode."))))
   (add-hook 'haskell-mode-hook #'+haskell|init-intero)
+  :config
   (add-hook 'intero-mode-hook #'flycheck-mode)
   (set! :lookup 'haskell-mode :definition #'intero-goto-definition))
 

modules/lang/haskell/autoload.el

@@ -1,10 +0,0 @@
-;;; lang/haskell/autoload.el -*- lexical-binding: t; -*-
-
-;;;###autoload
-(defun +haskell|init-intero ()
-  "Initializes `intero-mode' in haskell-mode, unless stack isn't installed.
-This is necessary because `intero-mode' doesn't do its own error checks."
-  (when (derived-mode-p 'haskell-mode)
-    (if (executable-find "stack")
-        (intero-mode +1)
-      (message "Couldn't find stack. Refusing to enable intero-mode."))))

modules/lang/javascript/config.el

@@ -183,8 +183,9 @@
 (def-package! eslintd-fix
   :commands (eslintd-fix-mode eslintd-fix)
   :config
-  (add-hook! 'eslintd-fix-mode-hook
-    (setq flycheck-javascript-eslint-executable eslintd-fix-executable)))
+  (defun +javascript|set-flycheck-executable-to-eslint ()
+    (setq flycheck-javascript-eslint-executable eslintd-fix-executable))
+  (add-hook 'eslintd-fix-mode-hook #'+javascript|set-flycheck-executable-to-eslint))
 
 
 (def-package! skewer-mode

modules/lang/org/config.el

@@ -306,7 +306,7 @@ between the two."
 (defun +org|setup-hacks ()
   "Getting org to behave."
   ;; Don't open separate windows
-  (map-put org-link-frame-setup 'file 'find-file)
+  (map-put org-link-frame-setup 'file #'find-file)
 
   ;; Let OS decide what to do with files when opened
   (setq org-file-apps