emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Prevent extra variable from being passed in macro.

Browse source 
In the PDF module, there is a macro that is used to prevent the
file-too-big prompt for PDFs since they're always too big. However, this
macro has an extra variable listed that then gets passed on to the
wrapped function and causes an error if the function doesn't support the
extra variable.

This fix simply checks if the extra value is present or not and only
calls the wrapped function with it if is actually present. After all,
the variable will still be nil even if nil isn't passed.
This commit is contained in:
Samuel Jackson 2021-07-04 14:59:29 -07:00
parent 2731685095
commit bb677cf7a5
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/tools/pdf/config.el
View file

@ -126,7 +126,9 @@
(defadvice! +pdf-suppress-large-file-prompts-a (orig-fn size op-type filename &optional offer-raw) (defadvice! +pdf-suppress-large-file-prompts-a (orig-fn size op-type filename &optional offer-raw)
:around #'abort-if-file-too-large :around #'abort-if-file-too-large
(unless (string-match-p "\\.pdf\\'" filename) (unless (string-match-p "\\.pdf\\'" filename)
(funcall orig-fn size op-type filename offer-raw)))) (if offer-raw
(funcall orig-fn size op-type filename offer-raw)
(funcall orig-fn size op-type filename)))))
(use-package! saveplace-pdf-view (use-package! saveplace-pdf-view