emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Revert +hub flag, but disable magithub by default

Browse source 
Must be enabled on a per-project basis. You can change this behavior by
setting +magit-hub-enabled-by-default to non-nil (before magit is
loaded).

Magithub has been made opt-in because:

1. Magithub is imposing, asking the user for a token, especially for
   users who don't use github (much or at all), but may occasionally
   have a project with a github remote.
2. magithub is really slow on first load for medium-to-large repos.
3. It's really easy to enable it through the magithub popup (H C e).
   magithub.enabled is saved into the project's .git/config file, so the
   setting will persist.

Also added a docstring to +magit-hub-features
This commit is contained in:
Henrik Lissner 2018-06-01 10:53:08 +02:00
parent 592205e1dd
commit bab530ea2e
No known key found for this signature in database
GPG key ID: 5F6C0EA160557395
3 changed files with 31 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
modules/tools/magit/autoload.el
View file

@ -51,3 +51,19 @@ format."
.owner.login .name)))
(magithub-clone repo dir)))
(magit-clone url-or-repo dir)))
;;
;; Advice
;;
;;;###autoload
(defun +magit*hub-settings--format-magithub.enabled ()
"Change the setting to display 'false' as its default."
(magit--format-popup-variable:choices "magithub.enabled" '("true" "false") "false"))
;;;###autoload
(defun +magit*hub-enabled-p ()
"Disables magithub by default."
(magithub-settings--value-or "magithub.enabled" nil
#'magit-get-boolean))