emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

General cleanup + refactor core.el

Browse source
This commit is contained in:
Henrik Lissner 2017-02-06 01:25:48 -05:00
parent b4c033d352
commit b8042bdaaa
4 changed files with 19 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

48
core/core-popups.el
View file

@ -222,54 +222,6 @@ monkey patch it to use pop-to-buffer, and to remember the previous window."
window t arg windmove-wrap-around t))
(advice-add 'windmove-find-other-window :override 'doom*ignore-window-parameters-in-popups))
;; (after! help-mode
;; ;; Help buffers use itself (or `other-window') to decide where to open
;; ;; followed links, which can be unpredictable. It should *only* replace the
;; ;; original buffer we opened the popup from. To fix this these three button
;; ;; types need to be redefined to set aside the popup before following a link.
;; (define-button-type 'help-function-def
;; :supertype 'help-xref
;; 'help-function (lambda (fun file)
;; (require 'find-func)
;; (when (eq file 'C-source)
;; (setq file (help-C-file-name (indirect-function fun) 'fun)))
;; (let ((location (find-function-search-for-symbol fun nil file)))
;; (doom/popup-close)
;; (switch-to-buffer (car location) nil t)
;; (if (cdr location)
;; (progn
;; (goto-char (cdr location))
;; (recenter nil))
;; (message "Unable to find location in file")))))
;; (define-button-type 'help-variable-def
;; :supertype 'help-xref
;; 'help-function (lambda (var &optional file)
;; (when (eq file 'C-source)
;; (setq file (help-C-file-name var 'var)))
;; (let ((location (find-variable-noselect var file)))
;; (doom/popup-close)
;; (switch-to-buffer (car location) nil t)
;; (if (cdr location)
;; (progn
;; (goto-char (cdr location))
;; (recenter nil))
;; (message "Unable to find location in file")))))
;; (define-button-type 'help-face-def
;; :supertype 'help-xref
;; 'help-function (lambda (fun file)
;; (require 'find-func)
;; (let ((location
;; (find-function-search-for-symbol fun 'defface file)))
;; (doom/popup-close)
;; (switch-to-buffer (car location) nil t)
;; (if (cdr location)
;; (progn
;; (goto-char (cdr location))
;; (recenter nil))
;; (message "Unable to find location in file"))))))
;; (after! magit
;; ;; Don't open files (from magit) within the magit popup
;; (advice-add 'magit-display-file-buffer-traditional :around 'doom*popup-save))