From b7836322f6f10ec689cfc5f8e4fe448f8297d8cd Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Thu, 23 Apr 2020 23:51:38 -0400 Subject: [PATCH] Refactor tide-mode's lookup handlers The remap bypass is no longer necessary. --- modules/lang/javascript/config.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/modules/lang/javascript/config.el b/modules/lang/javascript/config.el index cb7f067ee..479116ec7 100644 --- a/modules/lang/javascript/config.el +++ b/modules/lang/javascript/config.el @@ -179,9 +179,11 @@ to tide." (setq-default company-backends (delq 'company-tide (default-value 'company-backends)))) (set-company-backend! 'tide-mode 'company-tide) ;; navigation - (set-lookup-handlers! 'tide-mode - :definition '(tide-jump-to-definition :async t) - :references '(tide-references :async t)) + (set-lookup-handlers! 'tide-mode :async t + :definition #'tide-jump-to-definition + :references #'tide-references + :documentation #'tide-documentation-at-point) + (set-popup-rule! "^\\*tide-documentation" :quit t) ;; resolve to `doom-project-root' if `tide-project-root' fails (advice-add #'tide-project-root :override #'+javascript-tide-project-root-a) ;; cleanup tsserver when no tide buffers are left @@ -194,8 +196,6 @@ to tide." ;; `tide-mode-hook' is too early, so... (advice-add #'tide-setup :after #'eldoc-mode) - (define-key tide-mode-map [remap +lookup/documentation] #'tide-documentation-at-point) - (map! :localleader :map tide-mode-map "R" #'tide-restart-server