emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

refactor(lookup): move xwidget popup rule (#5598)

Browse source 
Setting the rules explicitly was preventing users from customizing how
xwidget popups should behave, so it was moved to the popup module as a 
global default.
This commit is contained in:
Björn Larsson 2021-10-10 18:22:13 +02:00 • committed by GitHub
parent 68c5336972
commit b2f27c2b4f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
modules/tools/lookup/autoload/xwidget.el
View file

@ -14,7 +14,6 @@
(setq xwidget-webkit-last-session-buffer +lookup--xwidget-webkit-last-session-buffer) (setq xwidget-webkit-last-session-buffer +lookup--xwidget-webkit-last-session-buffer)
(save-window-excursion (save-window-excursion
(xwidget-webkit-browse-url url new-session)) (xwidget-webkit-browse-url url new-session))
(with-popup-rules! '(("^\\*xwidget" :vslot -11 :size 0.35 :select nil)) (pop-to-buffer xwidget-webkit-last-session-buffer)
(pop-to-buffer xwidget-webkit-last-session-buffer))
(setq +lookup--xwidget-webkit-last-session-buffer xwidget-webkit-last-session-buffer (setq +lookup--xwidget-webkit-last-session-buffer xwidget-webkit-last-session-buffer
xwidget-webkit-last-session-buffer orig-last-session-buffer)))) xwidget-webkit-last-session-buffer orig-last-session-buffer))))

2
modules/ui/popup/config.el
View file

@ -155,6 +155,8 @@ prevent the popup(s) from messing up the UI (or vice versa)."
:slot 2 :vslot -8 :size 0.35 :select t) :slot 2 :vslot -8 :size 0.35 :select t)
("^\\*eww\\*" ; `eww' (and used by dash docsets) ("^\\*eww\\*" ; `eww' (and used by dash docsets)
:vslot -11 :size 0.35 :select t) :vslot -11 :size 0.35 :select t)
("^\\*xwidget"
:vslot -11 :size 0.35 :select nil)
("^\\*info\\*$" ; `Info-mode' ("^\\*info\\*$" ; `Info-mode'
:slot 2 :vslot 2 :size 0.45 :select t))) :slot 2 :vslot 2 :size 0.45 :select t)))
'(("^\\*Warnings" :vslot 99 :size 0.25) '(("^\\*Warnings" :vslot 99 :size 0.25)