From b0741336d182a4917447cd515077e18794bdf428 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Tue, 25 May 2021 14:15:33 -0400 Subject: [PATCH] Throw error if git < 2.28 To prevent issues like #5096. --- core/core-packages.el | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/core/core-packages.el b/core/core-packages.el index b99b061c5..d881c4b66 100644 --- a/core/core-packages.el +++ b/core/core-packages.el @@ -124,6 +124,17 @@ uses a straight or package.el command directly).") (lambda (&rest args) (message "%s" (cdr (apply #'doom-call-process args))))))) (unless (file-directory-p repo-dir) + (save-match-data + (unless (executable-find "git") + (user-error "Git isn't present on your system. Cannot proceed.")) + (let* ((version (cdr (doom-call-process "git" "version"))) + (version + (and (string-match "\\_<[0-9]+\\.[0-9]+\\(\\.[0-9]+\\)\\_>" version) + (match-string 0 version)))) + (if version + (when (version< version "2.28") + (user-error "Git %s detected! Doom requires git 2.28 or newer!" + version))))) (print! (start "Installing straight...")) (print-group! (cl-destructuring-bind (depth . options)