refactor!(csharp): remove omnisharp-emacs

BREAKING CHANGE: omnisharp-emacs is being removed as it is no longer
maintained and was deprecated (see
https://github.com/OmniSharp/omnisharp-emacs) in favor of the
omnisharp-roslyn LSP clients. It also no longer works in Emacs
28 (throwing an error when starting the server). Users need only enable
:lang (csharp +lsp) and install omnisharp-roslyn instead.

The :lang csharp module's README.org was intentionally left un-updated
because of a larger, upcoming documentation update which will reflect
these changes.

Close #5036

modules/lang/csharp/config.el

@@ -43,47 +43,6 @@ or terminating simple string."
     (unless (eq major-mode 'csharp-mode)
       (apply fn args))))
 
-(use-package! omnisharp
-  :unless (featurep! +lsp)
-  :commands omnisharp-install-server
-  :hook (csharp-mode-local-vars . omnisharp-mode)
-  :preface
-  (setq omnisharp-auto-complete-want-documentation nil
-        omnisharp-cache-directory (concat doom-etc-dir "omnisharp"))
-  :config
-  (set-company-backend! 'omnisharp-mode 'company-omnisharp)
-  (set-lookup-handlers! 'omnisharp-mode
-    :definition #'omnisharp-go-to-definition
-    :references #'omnisharp-find-usages
-    :documentation #'omnisharp-current-type-documentation)
-
-  ;; Kill the omnisharp server once the last csharp-mode buffer is killed
-  (add-hook! 'omnisharp-mode-hook
-    (add-hook 'kill-buffer-hook #'+csharp-kill-omnisharp-server-h nil t))
-
-  (map! :localleader
-        :map omnisharp-mode-map
-        "b" #'omnisharp-recompile
-        (:prefix "r"
-          "u"  #'omnisharp-fix-usings
-          "r"  #'omnisharp-rename
-          "a"  #'omnisharp-show-last-auto-complete-result
-          "o"  #'omnisharp-show-overloads-at-point)
-        (:prefix "g"
-          "u"  #'omnisharp-find-usages
-          "i"  #'omnisharp-find-implementations
-          "f"  #'omnisharp-navigate-to-current-file-member
-          "m"  #'omnisharp-navigate-to-solution-member
-          "M"  #'omnisharp-navigate-to-solution-file-then-file-member
-          "F"  #'omnisharp-navigate-to-solution-file
-          "r"  #'omnisharp-navigate-to-region
-          "ti" #'omnisharp-current-type-information
-          "td" #'omnisharp-current-type-documentation)
-        (:prefix "t"
-          "s" #'omnisharp-unit-test-at-point
-          "l" #'omnisharp-unit-test-last
-          "b" #'omnisharp-unit-test-buffer)))
-
 
 ;; Unity shaders
 (use-package! shader-mode

modules/lang/csharp/packages.el

@@ -4,8 +4,6 @@
 (package! csharp-mode :pin "093f0f21a9d04d79a380de145cbc42693ef8c76f")
 (package! csproj-mode :pin "a7f0f4610c976a28c41b9b8299892f88b5d0336c")
 (package! sln-mode :pin "0f91d1b957c7d2a7bab9278ec57b54d57f1dbd9c")
-(unless (featurep! +lsp)
-  (package! omnisharp :pin "5fad6835bee15792774183164dd423ba18cf1e01"))
 (when (featurep! +unity)
   (package! shader-mode :pin "d7dc8d0d6fe8914e8b6d5cf2081ad61e6952359c"))
 (when (featurep! +dotnet)