refactor: deprecate featurep! for modulep!

featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.

featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.

modules/ui/workspaces/autoload/evil.el

@@ -1,5 +1,5 @@
 ;;; ui/workspaces/autoload/evil.el -*- lexical-binding: t; -*-
-;;;###if (featurep! :editor evil)
+;;;###if (modulep! :editor evil)
 
 ;;;###autoload (autoload '+workspace:save "ui/workspaces/autoload/evil" nil t)
 (evil-define-command +workspace:save (&optional name)

modules/ui/workspaces/autoload/workspaces.el

@@ -318,7 +318,7 @@ workspace, otherwise the new workspace is blank."
 end of the workspace list."
   (interactive
    (list (or current-prefix-arg
-             (if (featurep! :completion ivy)
+             (if (modulep! :completion ivy)
                  (ivy-read "Switch to workspace: "
                            (+workspace-list-names)
                            :caller #'+workspace/switch-to

modules/ui/workspaces/config.el

@@ -206,7 +206,7 @@ stored in `persp-save-dir'.")
             ("xt" counsel-projectile-switch-project-action-run-term "invoke term from project root")
             ("X" counsel-projectile-switch-project-action-org-capture "org-capture into project")))
 
-  (when (featurep! :completion helm)
+  (when (modulep! :completion helm)
     (after! helm-projectile
       (setcar helm-source-projectile-projects-actions
               '("Switch to Project" . +workspaces-switch-to-project-h))))