refactor: deprecate featurep! for modulep!

featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.

featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.

modules/term/eshell/autoload/company.el

@@ -1,5 +1,5 @@
 ;;; term/eshell/autoload/company.el -*- lexical-binding: t; -*-
-;;;###if (featurep! :completion company)
+;;;###if (modulep! :completion company)
 
 ;; REVIEW Refactor me
 

modules/term/eshell/autoload/eshell.el

@@ -148,7 +148,7 @@ Once the eshell process is killed, the previous frame layout is restored."
 (defun +eshell/search-history ()
   "Search the eshell command history with helm, ivy or `eshell-list-history'."
   (interactive)
-  (cond ((featurep! :completion ivy)
+  (cond ((modulep! :completion ivy)
          (require 'em-hist)
          (let* ((ivy-completion-beg (eshell-bol))
                 (ivy-completion-end (point-at-eol))
@@ -163,9 +163,9 @@ Once the eshell process is killed, the previous frame layout is restored."
                         (ring-elements eshell-history-ring)))
                      :initial-input input
                      :action #'ivy-completion-in-region-action)))
-        ((featurep! :completion helm)
+        ((modulep! :completion helm)
          (helm-eshell-history))
-        ((featurep! :completion vertico)
+        ((modulep! :completion vertico)
          (forward-char 1) ;; Move outside of read only prompt text.
          (consult-history))
         ((eshell-list-history))))

modules/term/eshell/autoload/evil.el

@@ -1,5 +1,5 @@
 ;;; term/eshell/autoload/evil.el -*- lexical-binding: t; -*-
-;;;###if (featurep! :editor evil)
+;;;###if (modulep! :editor evil)
 
 ;;;###autoload (autoload '+eshell:run "term/eshell/autoload/evil" nil t)
 (evil-define-command +eshell:run (command bang)

modules/term/eshell/config.el

@@ -86,7 +86,7 @@ You should use `set-eshell-alias!' to change this.")
   (add-hook 'eshell-mode-hook #'smartparens-mode)
 
   ;; Persp-mode/workspaces integration
-  (when (featurep! :ui workspaces)
+  (when (modulep! :ui workspaces)
     (add-hook 'persp-activated-functions #'+eshell-switch-workspace-fn)
     (add-hook 'persp-before-switch-functions #'+eshell-save-workspace-fn))