refactor: deprecate featurep! for modulep!

featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.

featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.

modules/editor/multiple-cursors/autoload/evil-mc.el

@@ -1,5 +1,5 @@
 ;;; editor/multiple-cursors/autoload/evil-mc.el -*- lexical-binding: t; -*-
-;;;###if (featurep! :editor evil)
+;;;###if (modulep! :editor evil)
 
 ;;;###autoload
 (defun +multiple-cursors/evil-mc-toggle-cursors ()

modules/editor/multiple-cursors/config.el

@@ -11,12 +11,12 @@
 ;;; Packages
 
 (use-package! evil-multiedit
-  :when (featurep! :editor evil)
+  :when (modulep! :editor evil)
   :defer t)
 
 
 (use-package! iedit
-  :when (featurep! :completion vertico)
+  :when (modulep! :completion vertico)
   :defer t
   :init
   ;; Fix conflict with embark.
@@ -24,7 +24,7 @@
 
 
 (use-package! evil-mc
-  :when (featurep! :editor evil)
+  :when (modulep! :editor evil)
   :commands (evil-mc-make-cursor-here
              evil-mc-make-all-cursors
              evil-mc-undo-all-cursors
@@ -74,7 +74,8 @@
       (apply fn args)))
 
   ;; REVIEW This is tremendously slow on macos and windows for some reason.
-  (setq evil-mc-enable-bar-cursor (not (or IS-MAC IS-WINDOWS)))
+  (setq evil-mc-enable-bar-cursor (not (or (featurep :os 'macos)
+                                           (featurep :os 'windows))))
 
   (after! smartparens
     ;; Make evil-mc cooperate with smartparens better
@@ -171,7 +172,7 @@
   ;; mc doesn't play well with evil, this attempts to assuage some of its
   ;; problems so that any plugins that depend on multiple-cursors (which I have
   ;; no control over) can still use it in relative safety.
-  (when (featurep! :editor evil)
+  (when (modulep! :editor evil)
     (evil-define-key* '(normal emacs) mc/keymap [escape] #'mc/keyboard-quit)
 
     (defvar +mc--compat-evil-prev-state nil)

modules/editor/multiple-cursors/packages.el

@@ -2,7 +2,7 @@
 ;;; editor/multiple-cursors/packages.el
 
 (cond
- ((featurep! :editor evil)
+ ((modulep! :editor evil)
   (package! evil-multiedit :pin "23b53bc8743fb82a8854ba907b1d277374c93a79")
   (package! evil-mc :pin "63fd2fe0c213a4cc31c464d246f92931c4cb720f"))